[GitHub] storm pull request: STORM-1040. SQL support for Storm

2015-12-08 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/919#issuecomment-162965775 Thanks @haohui . Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-1040. SQL support for Storm

2015-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/919 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: STORM-1040. SQL support for Storm

2015-12-06 Thread wuchong
Github user wuchong commented on the pull request: https://github.com/apache/storm/pull/919#issuecomment-162390949 nice work! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] storm pull request: STORM-1040. SQL support for Storm

2015-12-04 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/919#issuecomment-162082605 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] storm pull request: STORM-1040. SQL support for Storm

2015-12-04 Thread unsleepy22
Github user unsleepy22 commented on the pull request: https://github.com/apache/storm/pull/919#issuecomment-161949861 LGTM +1, good work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: STORM-1040. SQL support for Storm

2015-12-03 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/919#discussion_r46649590 --- Diff: external/sql/README.md --- @@ -0,0 +1,101 @@ +# Storm SQL + +Compile SQL queries to Storm topologies. + +## Usage +

[GitHub] storm pull request: STORM-1040. SQL support for Storm

2015-12-03 Thread darionyaphet
Github user darionyaphet commented on the pull request: https://github.com/apache/storm/pull/919#issuecomment-161852522 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] storm pull request: STORM-1040. SQL support for Storm

2015-12-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/919#issuecomment-161739455 still +1 from me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-03 Thread haohui
Github user haohui commented on the pull request: https://github.com/apache/storm/pull/914#issuecomment-161738550 Currently the implementation does not support any aggregation (i.e., count, sum, max) yet. It will be added once StormSQL supports windowing. --- If your project is set u

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-03 Thread haohui
Github user haohui commented on the pull request: https://github.com/apache/storm/pull/914#issuecomment-161738187 For some reasons I can't reopen this PR now. Created #919 as a duplicate for this PR. Thanks everybody for the comments. I have addressed them in the latest PR.

[GitHub] storm pull request: STORM-1040. SQL support for Storm

2015-12-03 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/storm/pull/919 STORM-1040. SQL support for Storm This is a duplicate of #914. This PR rebases all the changes in the STORM-1040 branch towards the latest master. You can merge this pull request into a Git

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-03 Thread haohui
Github user haohui closed the pull request at: https://github.com/apache/storm/pull/914 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-03 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/914#discussion_r46582960 --- Diff: external/sql/README.md --- @@ -0,0 +1,98 @@ +# Storm SQL + +Compile SQL queries to Storm topologies. + +## Usage + +Run t

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-03 Thread hmcl
Github user hmcl commented on the pull request: https://github.com/apache/storm/pull/914#issuecomment-161718691 +1. Nice job. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-03 Thread darionyaphet
Github user darionyaphet commented on the pull request: https://github.com/apache/storm/pull/914#issuecomment-161654555 @haohui Thank you for you Great Work :+1: I want to know which SQL pattern had support ? such as count , distinct and sum ? --- If your project is set u

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-02 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/914#issuecomment-161491178 +1 Great work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-02 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/914#issuecomment-161486071 +1. Great work @haohui to pull it off :). Looking forward to get this into master branch. I've ran the tests with java 7 and java 8 all the tests are passing . Travis b

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-02 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/storm/pull/914 STORM-1040. SQL support for Storm. This PR rebases all the changes in the STORM-1040 branch towards the latest master. You can merge this pull request into a Git repository by running: $ git pul