Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/749
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/749#issuecomment-141851180
+1
I'll merge into master, and 0.10.x with #748
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
GitHub user randerzander opened a pull request:
https://github.com/apache/storm/pull/749
STORM-1055
missed a second map->hikariConfigMap.
Please also merge in 0.10.x, which has the same README issue.
You can merge this pull request into a Git repository by running:
$ g
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141844867
@randerzander
Please request another PR with same title. Please leave a reminder to new
PR so that I can take care of merging into 0.10.x-branch at that time.
-
Github user randerzander commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141844499
Unfortunately I missed an additional map->hikariConfigMap example further
down the README. Also, this applies to the 0.10.x branch as well. Is it
possible to merge t
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/748
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user randerzander commented on a diff in the pull request:
https://github.com/apache/storm/pull/748#discussion_r39935407
--- Diff: external/storm-jdbc/README.md ---
@@ -3,14 +3,16 @@ Storm/Trident integration for JDBC. This package includes
the core bolts and tri
to eit
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141840670
+1.
Since it modifies only doc., I'll merge into master right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141839836
You don't need to consider about Travis CI since you modifies only markdown
file.
It's due to random test failures.
---
If your project is set up for it, you can
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/748#discussion_r39935249
--- Diff: external/storm-jdbc/README.md ---
@@ -3,14 +3,16 @@ Storm/Trident integration for JDBC. This package includes
the core bolts and tri
to eith
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/748#discussion_r39935246
--- Diff: external/storm-jdbc/README.md ---
@@ -3,14 +3,16 @@ Storm/Trident integration for JDBC. This package includes
the core bolts and tri
to eith
Github user randerzander commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141827482
Not sure why the CI build failed, as I only modified the storm-jdbc README..
---
If your project is set up for it, you can reply to this email and have your
reply ap
GitHub user randerzander opened a pull request:
https://github.com/apache/storm/pull/748
STORM-1055
Fixed README by adding note about com.google.common.collect class usage,
also fixed hikariConfigMap reference in example.
You can merge this pull request into a Git repository by run
13 matches
Mail list logo
