[GitHub] storm pull request: STORM-1127: allow for boolean arguments (Flux)

2015-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: STORM-1127: allow for boolean arguments (Flux)

2015-11-06 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/832#issuecomment-154521316 +1. Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] storm pull request: STORM-1127: allow for boolean arguments (Flux)

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/832#issuecomment-154510125 To me the code looks good. +1, but I would like someone more familiar with Flux to also take a look. @ptgoetz can you take a look, or point out someone who would

[GitHub] storm pull request: STORM-1127: allow for boolean arguments

2015-10-29 Thread ashnazg
GitHub user ashnazg opened a pull request: https://github.com/apache/storm/pull/832 STORM-1127: allow for boolean arguments You can merge this pull request into a Git repository by running: $ git pull https://github.com/ashnazg/storm boolArgs Alternatively you can review and