[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/889 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2016-01-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/889#issuecomment-170088345 @d2r done I updated the comment in Config. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2016-01-08 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/889#issuecomment-170073038 * Downloaded 0.11 source & pulled in this branch * ran the move_packages.sh, build and unpacked the tarball * launched daemons from the unpacked 0.11+hack build * d

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2016-01-07 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/889#issuecomment-169780775 I just filed http://dev.clojure.org/jira/browse/CLJ-1876 for the issue I was seeing with the require. --- If your project is set up for it, you can reply to this email a

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2016-01-07 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/889#issuecomment-169775907 OK I finally tracked down some intermittent failures I was seeing when running the clojure word count example. It looks like there is an issue in clojure where how we ar

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2016-01-07 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/889#issuecomment-169690819 Looks OK to me overall. It would be nice to have a follow-on Jira Issue or Sub-Task to remove/revert the changes we need to bootstrap the testing for this (dev-tools,

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2016-01-07 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/889#discussion_r49078953 --- Diff: storm-rename-hack/pom.xml --- @@ -0,0 +1,107 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2015-12-10 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/889#issuecomment-163754893 The test failures appear to be unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2015-11-19 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/889#issuecomment-158100747 I am a +1. I like this backward compatibility feature for smooth migration to package renaming. The changes look good to me. I ran some tests with topology jar compi

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2015-11-17 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/889#issuecomment-157487487 Because this is a non-backwards compatible change, and the mailing lists have discussed moving the version numbers over to 1.0.0-SNAPSHOT I am happy to make that change h

[GitHub] storm pull request: STORM-1202: Migrate APIs to org.apache.storm, ...

2015-11-17 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/889 STORM-1202: Migrate APIs to org.apache.storm, but try to provide some form of backwards compatability This is not a typical pull request, because changing the packages is a huge task, and keeping it