Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/887
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-158199509
@ptgoetz
+1 the changes look good and my manual tests all pass.
I Agree the it kind of ugly. Ideally what we need to do is to talk to
sigar and see if they
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-158184985
@revans2 I couldn't get the maven dependency plugin to do what I wanted, so
I changed tactics. I switched to using the maven antrun plugin to download and
unpack the siga
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-158094151
@ptgoetz Yes you are correct about the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157880047
@revans2 Ah... okay. So we need to change `resources/resources` to just
`resources`, and remove the `-1.6.4` from the libraries, correct?
That should be doable wi
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157876251
yes that is it. When I moved
`resources/libsigar-universal64-macosx-1.6.4.dylib` to
`resources/libsigar-universal64-macosx.dylib` and reran it all worked.
---
If your
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157874959
I just did a diff of the contents of the two jars, old and new(this patch
plus me moving the native libraries) and I came up with the following. Around
the max native pie
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157873921
In master
https://github.com/apache/storm/tree/master/external/storm-metrics/src/main/resources
gets mapped into the base directory of the jar. So
https://github.com/ap
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157869384
@revans2 That directory structure is what's in master right now:
https://github.com/apache/storm/tree/master/external/storm-metrics/src/main/resources/resources
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157868784
@revans2 How are you running it (i.e. local/remote/unit test)? My first
thought is that we may just need to bind the dependency plugin to a different
maven lifecycle.
-
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157862181
Even with changing the directory I am getting
```
java.lang.UnsatisfiedLinkError: org.hyperic.sigar.Sigar.getPid()J
at org.hyperic.sigar.Sigar.getPid(Nativ
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157858618
Sorry about the comments after giving it a +1. I manually ran
LatencyVsThroughput and saw that it was not working.
---
If your project is set up for it, you can reply t
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/887#discussion_r45257318
--- Diff: external/storm-metrics/pom.xml ---
@@ -55,4 +62,28 @@
provided
+
+
+
+org.apache.mave
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/887#discussion_r45257261
--- Diff: external/storm-metrics/pom.xml ---
@@ -48,6 +48,13 @@
+ org.fusesource
+ sigar
+ 1.6.4
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157857431
Actually I just tried to run this and it looks like the libraries are under
`resources/resources/` instead of just `resources/` because of this I am
getting linking erro
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157843581
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157827199
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157705671
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/887
STORM-1213: Remove sigar binaries from source tree
See https://issues.apache.org/jira/browse/STORM-1213 for description.
Also removes the LICENSE entry for sigar, since I believe that is
unn
19 matches
Mail list logo
