Github user abellina commented on the pull request:
https://github.com/apache/storm/pull/1191#issuecomment-217513183
@abhishekagarwal87 @redsanket any other changes that need made?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user abellina commented on the pull request:
https://github.com/apache/storm/pull/1191#issuecomment-195021005
@abhishekagarwal87 @redsanket made those fixes, I rebased the branch to
clean up history.
---
If your project is set up for it, you can reply to this email and have yo
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1191#discussion_r55696301
--- Diff:
storm-core/test/jvm/org/apache/storm/security/auth/AuthUtilsTest.java ---
@@ -0,0 +1,240 @@
+/**
+ * Licensed to the Apache Software Found
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1191#discussion_r55672749
--- Diff:
storm-core/test/jvm/org/apache/storm/security/auth/AuthUtilsTest.java ---
@@ -0,0 +1,240 @@
+/**
+ * Licensed to the Apache Softwa
Github user abellina commented on the pull request:
https://github.com/apache/storm/pull/1191#issuecomment-193974692
Test failures appear to be unrelated to my change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
GitHub user abellina reopened a pull request:
https://github.com/apache/storm/pull/1191
STORM-1233: Port AuthUtilsTest to java
I did a little bit of refactoring in AuthUtils:
- Using Hex.encodeHexString in makeDigestPayload instead of StringBuilder
and String.format
- Factor
Github user abellina closed the pull request at:
https://github.com/apache/storm/pull/1191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1191#discussion_r55316972
--- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AuthUtils.java
---
@@ -240,8 +290,8 @@ public static Subject populateSubject(Subject sub
Github user abellina commented on a diff in the pull request:
https://github.com/apache/storm/pull/1191#discussion_r55310666
--- Diff:
storm-core/test/jvm/org/apache/storm/security/auth/AuthUtilsTest.java ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Founda
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/storm/pull/1191#discussion_r55305746
--- Diff:
storm-core/test/jvm/org/apache/storm/security/auth/AuthUtilsTest.java ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundat
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/storm/pull/1191#discussion_r55303331
--- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AuthUtils.java
---
@@ -81,35 +80,88 @@ public static Configuration GetConfiguration(Map
storm_con
GitHub user abellina opened a pull request:
https://github.com/apache/storm/pull/1191
STORM-1233: Port AuthUtilsTest to java
I did a little bit of refactoring in AuthUtils:
- Using Hex.encodeHexString in makeDigestPayload instead of StringBuilder
and String.format
- Factored
12 matches
Mail list logo
