[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188461160 @Parth-Brahmbhatt I'll just go ahead and merge it. It is a very small change and was already marked for 1.0. --- If your project is set up for it, you can reply to thi

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188447027 @knusbaum I think we should. WE have see RejectedExecutionException on > 5 different customer clusters. I can backport this if others also agree. --- If your p

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188446369 @Parth-Brahmbhatt I merged this and resolved the jira, but the the jira's resolved version was listed as 1.0. I changed it to 2.0, but do we want to backport this to 1.

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188409357 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188215628 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread satishd
Github user satishd commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188196306 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-23 Thread wuchong
Github user wuchong commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188100464 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-23 Thread Parth-Brahmbhatt
GitHub user Parth-Brahmbhatt opened a pull request: https://github.com/apache/storm/pull/1144 STORM-1569: Adding option in nimbus to specify request queue size in … …config. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Part