[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-20 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1229#issuecomment-197915743 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1229#issuecomment-197760319 #1227 is based on 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1227#issuecomment-198153364 @revans2 Very odd indeed... It should give us error because of storm-mongo module. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1227 STORM-1602 Blobstore UTs are failed on Windows * ensures objects of InputStream / OutputStream are closed after used * clojure: with-open * java: try-with-resource * skip

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1227#issuecomment-198032722 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1227#issuecomment-197760146 #1229 is based on master branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1227#issuecomment-197885702 I assume they all pass on windows so +1 The test failure looks like it is a bug with the mongodb pom.xml that JDK8 does not like but JDK7 seems OK with. Very

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

2016-03-19 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1229 STORM-1602 Blobstore UTs are failed on Windows * ensures objects of InputStream / OutputStream are closed after using * clojure: with-open * java: try-with-resource * skip