[GitHub] storm pull request: STORM-1701 simple JSON mapping

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1327#issuecomment-216479478 @kristopherkane Yes, squash and push with `force` option. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] storm pull request: STORM-1701 simple JSON mapping

2016-05-01 Thread kristopherkane
Github user kristopherkane commented on the pull request: https://github.com/apache/storm/pull/1327#issuecomment-216095877 You're right. There is no sense in replaying the same broken input. I'm conflicted on what the right approach is to notify the topology owner of corrupt JSON or

[GitHub] storm pull request: STORM-1701 simple JSON mapping

2016-04-11 Thread dossett
Github user dossett commented on the pull request: https://github.com/apache/storm/pull/1327#issuecomment-208371424 There is an interesting issue here. If the tuple contains malformed JSON such that `rowKey(tuple)` throws a ParseException then the HBase bolt will never process that m

[GitHub] storm pull request: STORM-1701 simple JSON mapping

2016-04-10 Thread dossett
Github user dossett commented on a diff in the pull request: https://github.com/apache/storm/pull/1327#discussion_r59150105 --- Diff: external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java --- @@ -68,7 +69,13 @@ public void execute(Tuple tuple) {

[GitHub] storm pull request: STORM-1701 simple JSON mapping

2016-04-10 Thread kristopherkane
GitHub user kristopherkane opened a pull request: https://github.com/apache/storm/pull/1327 STORM-1701 simple JSON mapping You can merge this pull request into a Git repository by running: $ git pull https://github.com/kristopherkane/storm master Alternatively you can review