[GitHub] storm pull request: STORM-469

2015-05-15 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/388#issuecomment-102503828 @d2r Thanks, and that is another thing - why do we have log link on port number? That does not make any sense at all.The truncated text is where the user expects a

[GitHub] storm pull request: STORM-469

2015-03-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-469

2015-03-11 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/388#issuecomment-78327431 +1 I think the change is a good start to this problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request: STORM-469

2015-02-03 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/storm/pull/385#issuecomment-72723038 created separate pulls. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: STORM-469

2015-01-20 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/388#issuecomment-70753999 I agree it is definitely a great idea to put the link on the UI, and this is what #150 did when it added `errorWorkerLogLink` to storm. But I am not sure it adds

[GitHub] storm pull request: STORM-469

2015-01-20 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/storm/pull/388#issuecomment-70787226 @d2r Thanks, and that is another thing - why do we have log link on port number? That does not make any sense at all.The truncated text is where the user expects a

[GitHub] storm pull request: STORM-469

2015-01-19 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/storm/pull/385#issuecomment-70607612 Thanks Harshch for having a look.Somehow you seem to have reviewed both storm-469 and storm-528 commits together? 1. commit 2931487 is for storm-469, tested and

[GitHub] storm pull request: STORM-469

2015-01-19 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/storm/pull/385#issuecomment-70571273 jmlogan: you are right about the extra files.few more changes.will update commit.thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: STORM-469

2015-01-19 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/385#issuecomment-70523175 -1. I don't think the change is necessary. Storm ships with a logviewer daemon. If users want more details on some exception in ui, they have the ability to do