Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-74791899
@HeartSaVioR @dashengju I took care of it as part of this PR
https://github.com/apache/storm/pull/434 . Thanks.
---
If your project is set up for it, you can reply to
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-74376482
@dashengju @harshach
Since there's no exec on Windows, we can check os, and use sub.call() if
it's Windows, and use os.execvp() if it's not Windows.
If you
Github user dashengju commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-72795383
@harshach , ok, you or @HeartSaVioR should responsible for fix this bug,
because I just know how to fix it in linux, but not in windows.
thanks
---
If your
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-72794546
@dashengju I second that ,just recently noticed it . We can file a
follow-up jira for it.
---
If your project is set up for it, you can reply to this email and have
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-67813766
Should this be pluggable ?
storm-master/bin/storm Python Script
storm-master/external/storm-cli --- Proivide Bash Shell / Windows cmd
Shell or any other
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-67860921
Thanks @HeartSaVioR merged PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ChitturiPadma commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-67764141
@HeartSavioR, if it works on distributed mode in windows cluster without
any exceptions, you cab go ahead and merge it. But the users on windows should
be given
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-67792351
@harshach
Otherwise we can try to change storm.cmd to call bin\storm.
I heard storm.cmd can register storm to Windows Service, so we could
achieve it by
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-67735825
@harshach Thanks for reviewing! :)
@ptgoetz @revans2 Since it would be tested from @ChitturiPadma and
@harshach, and two +1 from committers, so we can merge it. :D
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-67712765
@HeartSaVioR sorry about taking so long to review this. Its been a
challenge to get a windows box :).
I tested this both on windows 8 and centos6.5 I tested all the
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-65885963
Could anybody check/review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-61983313
Sorry it took me so long to respond. The changes look good to me, but I
don't have a windows box so I cannot test the windows support, I am +1 on the
changes so far, but
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-61908678
@revans2 @ptgoetz
Hello. Any updates on it?
From some JIRA issues we already talked that it will be better to have
'unified' storm script.
So when my
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-61919968
@HeartSaVioR sorry for the delay. I will test and reply when I have the
chance. I would encourage others to do the same as well.
---
If your project is set up for it,
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-57930437
@ChitturiPadma I've just test killing topology using Storm 0.9.2.
There're some warning but supervisor seems to not killed.
It seems to have an issue you
Github user ChitturiPadma commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-57932225
When i worked on storm-0.9.0-rc2, the issue existed only with modified
python script that works on windows. storm.cmd doesnt show have this issue in
file deletion.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-57926268
@ChitturiPadma Thanks for sharing experience.
I'll test on it.
Btw, does storm.cmd runs normally with this scenario?
---
If your project is set up for it, you
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-57764337
In Windows, users should run command ```PYTHON_PATH\python bin\storm
blabla...```.
---
If your project is set up for it, you can reply to this email and have your
19 matches
Mail list logo
