Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/257#issuecomment-61584109
@clockfly @revans2
I've found that I've misunderstand this patch. Comment 2 is wrong, sorry
about it.
Regarding comment 1, if performance is not a concern, it'
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/257#issuecomment-61579721
@HeartSaVioR,
The performance is not a concern, since taskToQueueId will only be modified
for a few times.
+1 for the patch
---
If your project is set
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/257#issuecomment-57566732
I have some comments about it.
1. Could we use RWLock to getMessageQueueId()? Maybe we could avoid copying
entire map if it plays well.
2. If there're some
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/257#issuecomment-57559023
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
