Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-170581717
+1 again. It would be nice to add some documentation, but I would like to
get this in for a 1.0 branch, so we can probably do it in a follow on JIRA.
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/432
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user atdixon commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-170156299
I've tested this fix against the latest code (see thread above for how I am
testing).
Anything else to consider?
I've noticed there is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-169146012
@atdixon sorry this dropped off of my radar. The code looks like it needs
to be upmerged and retested, but it looks like it should not be too difficult.
Mostly
Github user atdixon commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-169162327
@revans2 i've rebased and made updates per cr. mvn tests are passing. will
try to test full integration scenario tomorrow.
---
If your project is set up for it, you can
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/432#discussion_r42052527
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -306,7 +327,30 @@ public static ComponentCommon
getComponentCommon(StormTopology
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-148199687
@revans2, @harshach Any updates here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-82411216
The code looks good to me and there is a JIRA for it. I am +1, but
@harshach I'll wait to hear from you before I check anything in.
---
If your project is set up for
Github user atdixon commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-82580384
@harshach implemented your suggestions, thank you.
The *storm* configuration I used to test (w/ single zk node, too) is in the
first comment of this thread.
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/432#discussion_r26588593
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -363,9 +384,30 @@ public static CuratorFramework newCurator(Map conf,
ListString servers,
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/432#discussion_r26591966
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -363,9 +384,30 @@ public static CuratorFramework newCurator(Map conf,
ListString servers,
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-78750701
@atdixon @revans2 with this patch can a user who doesn't want use exhibitor
avoid it by not having the config or the user must have the config in their
storm.yaml.
---
Github user atdixon commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-78386437
Done, I've added the ticket number to the title. Here is the ticket:
https://issues.apache.org/jira/browse/STORM-702
---
If your project is set up for it, you can reply
Github user atdixon commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-78415948
Note: I've added a short bit on design options and why I recommend this
implementation in a comment attached to the JIRA ticket.
---
If your project is set up for it,
14 matches
Mail list logo
