[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86542171 @HeartSaVioR yes, but this is a very easy cherry-pick, when we are depleting code. I am running the tests on 0.10.x-branch now to be sure everything looks good, and then I

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86541464 @revans2 Thanks for merging! Especially I know that cherry-picking commits is not a easy way to do. ;) --- If your project is set up for it, you can reply to this ema

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86539867 OK, I'll merge this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86526814 I think we should remove these 2 files from all branches, since we'll introduce new classes if we need. --- If your project is set up for it, you can reply to this em

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86521810 I am +1 on the change, but my only question is do we want to do this only for all branches? or only for 0.10.X? --- If your project is set up for it, you can reply to thi

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-25 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86293223 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and