[GitHub] storm pull request: STORM-786: KafkaBolt should ack tick tuples

2015-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: STORM-786: KafkaBolt should ack tick tuples

2015-04-20 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/522#issuecomment-94575511 +1 looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] storm pull request: STORM-786: KafkaBolt should ack tick tuples

2015-04-20 Thread miguno
Github user miguno commented on the pull request: https://github.com/apache/storm/pull/522#issuecomment-94378665 We already [received a +1](https://github.com/apache/storm/pull/275#issuecomment-94068063) from @nathanmarz. --- If your project is set up for it, you can reply to this e

[GitHub] storm pull request: STORM-786: KafkaBolt should ack tick tuples

2015-04-16 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/storm/pull/522 STORM-786: KafkaBolt should ack tick tuples [STORM-512](https://issues.apache.org/jira/browse/STORM-512) (KafkaBolt doesn't handle ticks properly) adds special-casing of tick tuples. What is missing