Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-135494026
Great work @hmcl. Merged into trunk. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/665
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37883322
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -0,0 +1,107 @@
+package org.apache.storm.solr.bolt;
+
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37883211
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/AbstractSolrBolt.java
---
@@ -0,0 +1,33 @@
+package org.apache.storm.solr.bolt;
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37897758
--- Diff: external/storm-solr/README.md ---
@@ -0,0 +1,188 @@
+# Storm Solr
+Storm and Trident integration for Apache Solr. This package includes a
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37898067
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi)
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37883364
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/AbstractSolrBolt.java
---
@@ -0,0 +1,33 @@
+package org.apache.storm.solr.bolt;
+
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37883234
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -0,0 +1,107 @@
+package org.apache.storm.solr.bolt;
+
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37898379
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi)
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37898773
--- Diff:
external/storm-solr/src/test/java/org/apache/storm/solr/topology/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi)
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37883137
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrJsonMapper.java
---
@@ -0,0 +1,97 @@
+package org.apache.storm.solr.mapper;
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-134657971
+1 . @Parth-Brahmbhatt @ptgoetz can you take a look at it as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37882952
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrJsonMapper.java
---
@@ -0,0 +1,97 @@
+package org.apache.storm.solr.mapper;
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37899232
--- Diff: pom.xml ---
@@ -169,8 +169,9 @@
moduleexternal/storm-redis/module
moduleexternal/storm-eventhubs/module
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37901014
--- Diff: external/storm-solr/pom.xml ---
@@ -0,0 +1,106 @@
+?xml version=1.0 encoding=UTF-8?
+project xmlns=http://maven.apache.org/POM/4.0.0;
+
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-134693551
I left a few minor comments. There are a few .gitignore files that can be
removed, and the documentation should use the Maven shade plugin, instead of
the assembly
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928677
--- Diff:
external/storm-solr/src/test/java/org/apache/storm/solr/topology/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi)
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928671
--- Diff: pom.xml ---
@@ -169,8 +169,9 @@
moduleexternal/storm-redis/module
moduleexternal/storm-eventhubs/module
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928702
--- Diff: external/storm-solr/README.md ---
@@ -0,0 +1,188 @@
+# Storm Solr
+Storm and Trident integration for Apache Solr. This package includes a
bolt
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928692
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi)
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928682
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/.gitignore ---
@@ -0,0 +1 @@
+# Created by .ignore support plugin (hsz.mobi)
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37928717
--- Diff: external/storm-solr/pom.xml ---
@@ -0,0 +1,106 @@
+?xml version=1.0 encoding=UTF-8?
+project xmlns=http://maven.apache.org/POM/4.0.0;
+
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-134782918
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37147769
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilder.java
---
@@ -0,0 +1,53 @@
+package
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-131583675
I volunteer to be sponsor for this connector
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36987568
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -0,0 +1,107 @@
+package org.apache.storm.solr.bolt;
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-130751200
I made a initial pass on the PR. Overall it looks good to me. It needs
README to document on how to use Bolt and TridentState.
---
If your project is set up for it,
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36998880
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilder.java
---
@@ -0,0 +1,53 @@
+package
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36992356
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrJsonMapper.java
---
@@ -0,0 +1,97 @@
+package org.apache.storm.solr.mapper;
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36993719
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilder.java
---
@@ -0,0 +1,53 @@
+package
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36990730
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/AbstractSolrBolt.java
---
@@ -0,0 +1,33 @@
+package org.apache.storm.solr.bolt;
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36990357
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -0,0 +1,107 @@
+package org.apache.storm.solr.bolt;
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36863654
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/AbstractSolrBolt.java
---
@@ -0,0 +1,33 @@
+package org.apache.storm.solr.bolt;
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/665
STORM-851: Storm Solr Connector
1. SolrUpdate Bolt
2. Trident State implementation
3. Fields Mapper
4. JSON Mapper
5. Integration Tests
You can merge this pull request into a Git
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-127483109
I am planning on pushing a few more unit tests while the community does the
review. I have provided a set of functional tests that use the Solr
gettingstarted example. I
35 matches
Mail list logo
