[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/614#issuecomment-121967209 @HeartSaVioR I'm not sure exactly what is happening here either but the patch does not hurt anything. If you want to dig more into exactly what is happening we can file

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/614 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/614#issuecomment-121966256 Hmm, when I build it on my mac everything shows up fine, either with or without this fix. +1 --- If your project is set up for it, you can reply to this email and have y

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-15 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/614#issuecomment-121798363 @HeartSaVioR I came across the same issue when I created binary dist from master too, and that's why I pushed this PR. --- If your project is set up for it, y

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-15 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/614#issuecomment-121776092 Now I'm not sure to know what happens. I created binary dist file from master, 0.10.x-branch, 0.9.x-branch and extract it, and confirmed that bin/storm doesn'

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-15 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/614#issuecomment-121767694 I suffered this issue when I created binary dist file and install manually. bin/storm script doesn't have permission for "execute". --- If your project is set up

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-06 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/614#issuecomment-118785292 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-05 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/614#issuecomment-118686693 Thanks @HeartSaVioR . I have fixed as you mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/614#issuecomment-118436035 How about setting file mode to storm_env.ini too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-02 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/613#issuecomment-118246436 @HeartSaVioR I have removed unrelated commits and pushed to https://github.com/apache/storm/pull/614 --- If your project is set up for it, you can reply to thi

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-02 Thread caofangkun
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/614 STORM-924:Set the file mode of the files included when packaging release packages …ase packages You can merge this pull request into a Git repository by running: $ git pull https://github.

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-02 Thread caofangkun
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/613#issuecomment-118211480 I like the change. It would be better to set files' mode explicitly whenever it needs. Only thing that I'm afraid of is unrelated commits, which are having no

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-02 Thread lazyval
Github user lazyval commented on the pull request: https://github.com/apache/storm/pull/613#issuecomment-118044177 :+1: For those who wonders what this octal numbers mean, there is a great [*humanizator*](http://permissions-calculator.org/decode/0644/). --- If your project

[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-02 Thread caofangkun
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/613 STORM-924:Set the file mode of the files included when packaging release packages You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/