[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-04-08 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-207432109 @hustfxj Please take another look when you have time, I think this feature is done :) The test failure seems to occur intermittently in storm-kafka, looks unrelate

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-04-08 Thread srdo
Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-04-08 Thread srdo
GitHub user srdo reopened a pull request: https://github.com/apache/storm/pull/1209 STORM-956: When the execute() or nextTuple() hang on external resources, stop the Worker's heartbeat The previous PR at https://github.com/apache/storm/pull/647 doesn't look active anymore. Having S

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-21 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-199348649 Sorry, pressed the close button by accident. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-21 Thread srdo
GitHub user srdo reopened a pull request: https://github.com/apache/storm/pull/1209 STORM-956: When the execute() or nextTuple() hang on external resources, stop the Worker's heartbeat The previous PR at https://github.com/apache/storm/pull/647 doesn't look active anymore. Having S

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-21 Thread srdo
Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-21 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-199348274 The test failure looks to be the same as on master https://travis-ci.org/apache/storm/jobs/117200843. It ran locally for me with all-tests. --- If your project is set up

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-21 Thread srdo
GitHub user srdo reopened a pull request: https://github.com/apache/storm/pull/1209 STORM-956: When the execute() or nextTuple() hang on external resources, stop the Worker's heartbeat The previous PR at https://github.com/apache/storm/pull/647 doesn't look active anymore. Having S

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-21 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-199321366 The hang checks should now support writing errors to Zookeeper, extending the timeout by interacting with an OutputCollector, setting different time limits per component, a

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-20 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-198878063 Will reopen this when the PR is closer to done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-20 Thread srdo
Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-15 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-197155218 @srdo I mean that we can report errors into Zookeeper whether the option is enabled. And the metrisc is not only record the counter, but also the timeout time. --- I

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-15 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-196988005 I'll add some tests that errors are going into Zookeeper when executors hang soon/that workers are getting killed only if the option is enabled, and will take a look at add

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-14 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-196220384 Spout itself emits messages by SpoutOutputCollector 's emit(). If lots of messages failed, then acker will trigger SpoutOutputCollector emits those failed messages. It

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-14 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-196213692 It looks to good. I also hope we should see this done through both the metrics system and through writing an error into zookeeper that would show up on the UI for the c

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-13 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1209#issuecomment-196028832 I don't want this merged yet, just posted to get feedback :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm pull request: STORM-956: When the execute() or nextTuple() h...

2016-03-13 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/1209 STORM-956: When the execute() or nextTuple() hang on external resources, stop the Worker's heartbeat The previous PR at https://github.com/apache/storm/pull/647 doesn't look active anymore. Having Sto