Github user jnioche commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-188994648
thanks for having taken the time to do it @revans2, much appreciated
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-188946892
Thanks @jnioche I merged this into master and branch 1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-188932487
@jnioche just me not getting to it. Will merge it in now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jnioche commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-188872715
Anything blocking this from being committed (apart from committers'
availability)?
---
If your project is set up for it, you can reply to this email and have your
Github user jnioche commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-186561314
@ptgoetz perfect, thanks. BTW I really like the HDFS module, great work!
Would be good to have compression for HdfsBolt, I might have a go at
implementing that.
---
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-186459994
@jnioche yes, this can go into 1.0, all you need to do is request so (which
you have). No need to open a second pull request unless it doesn't apply
cleanly to the 1.x
Github user jnioche commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-186435209
@dossett good idea - I have just committed your suggestion
@revans2 and @ptgoetz \: will the content of the master branch become 2.x
and if so could this be
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-186370134
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-185828905
Would there be a drawback to making all of the abstract methods protected
if we want to support end user extensions?
---
If your project is set up for it, you can
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-185815858
+1 looks fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1122
storm-hdfs : change visibility of create and closeOutputFile methods to
protected
When extending HdfsBolt it can be useful to be able to override the methods
createOutputFile() or
12 matches
Mail list logo
