Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1605#discussion_r80023848
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -330,11 +328,9 @@ public void ack(Object messageId) {
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1605#discussion_r80004187
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -330,11 +328,9 @@ public void ack(Object messageId) {
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1605#discussion_r79571602
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -330,11 +328,9 @@ public void ack(Object messageId) {
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1605#discussion_r79572783
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryService.java
---
@@ -29,14 +29,18 @@
*/
public interf
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1605#discussion_r79570505
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -144,7 +145,12 @@ public String t
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/1605
STORM-2014: Put logic around dropping messages into RetryService, remâ¦
â¦ove maxRetry setting from new KafkaSpout
https://issues.apache.org/jira/browse/STORM-2014
This PR removes ma
