Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1783
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r90260820
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,81 @@
*
*/
public class
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r89250230
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,81 @@
*
*/
public class
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88968371
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,85 @@
*
*/
public class
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88964361
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88949169
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88946224
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,85 @@
*
*/
public class
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88946112
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java
---
@@ -37,8 +37,7 @@
public abstract class
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88945680
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88945432
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
--- End diff --
That's happened because of my IDE. I would recommend adding the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88938511
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88938308
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88939110
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88940442
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,85 @@
*
*/
public class
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88937595
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
--- End diff --
Could you please revert the spacing back to how it was before?
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88938675
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88941608
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,85 @@
*
*/
public class
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88943466
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,85 @@
*
*/
public class
18 matches
Mail list logo
