GitHub user ambud opened a pull request:
https://github.com/apache/storm/pull/1922
STORM-2344 Flux YAML File Viewer for Nimbus UI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ambud/storm master
Alternatively you can review an
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99510863
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
Missing apache license. And I guess we may need a link fr
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99719977
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
@vesense I thought someone will ask for that :D
J
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99745686
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
Also, should we plan on back porting this to 0.10.x and 1.x
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99745970
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
I think @vesense means that Storm UI index page shoul
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99747044
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
Sorry I misunderstood. @HeartSaVioR not sure what location
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99760485
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
No it shouldn't be only for Ambari. I'll see where's
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99760968
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
If we can have icon then we can place it to the left
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99776407
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
I have the same idea as @HeartSaVioR :smile:
---
If yo
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99961278
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
Added a link on the top right hand side after the username
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99963942
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
Not sure which is better between F (for Flux) and Y (
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99964052
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
And posting screenshot to the comment would help us t
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99966356
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+
--- End diff --
https://cloud.githubusercontent.com/assets/9707358/227
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1922
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
14 matches
Mail list logo
