Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1999
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106299675
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106299441
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106291741
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106283741
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void commitOffsetsForAckedTu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106280062
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106263320
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void commitOffsetsForAckedTu
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1999
STORM-2409: Storm-Kafka-Client KafkaSpout Support for Failed and NullTuples
- Created config property to make emit null tuples configurable
- Ack directly null tuples that are not emitted
You c
