Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130449657
--- Diff:
examples/storm-kafka-client-examples/src/main/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java
---
@@ -0,0 +1,103 @@
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130438812
--- Diff:
examples/storm-kafka-client-examples/src/main/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java
---
@@ -0,0 +1,103 @@
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130438441
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -21,15 +21,10 @@
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130438296
--- Diff:
examples/storm-kafka-client-examples/src/main/java/org/apache/storm/kafka/trident/TridentKafkaClientWordCountNamedTopics.java
---
@@ -42,72 +42,68
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130435817
--- Diff: examples/storm-kafka-client-examples/pom.xml ---
@@ -42,7 +42,9 @@
org.apache.storm
storm-kafka
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130435628
--- Diff: examples/storm-kafka-client-examples/README.markdown ---
@@ -0,0 +1,10 @@
+## Usage
+This module contains example topologies demonstrating
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130418867
--- Diff: examples/storm-kafka-client-examples/pom.xml ---
@@ -42,7 +42,9 @@
org.apache.storm
storm-kafka
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130419415
--- Diff: examples/storm-kafka-client-examples/pom.xml ---
@@ -73,19 +75,27 @@
org.apache.storm
storm-kafka-client
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130425918
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -21,15 +21,10 @@
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130431738
--- Diff: examples/storm-kafka-client-examples/pom.xml ---
@@ -73,19 +75,27 @@
org.apache.storm
storm-kafka-client
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130431776
--- Diff: examples/storm-kafka-client-examples/pom.xml ---
@@ -73,19 +75,27 @@
org.apache.storm
storm-kafka-client
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130428532
--- Diff:
examples/storm-kafka-client-examples/src/main/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java
---
@@ -0,0 +1,103 @@
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130429805
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -21,15 +21,10 @@
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130417840
--- Diff: examples/storm-kafka-client-examples/README.markdown ---
@@ -0,0 +1,10 @@
+## Usage
+This module contains example topologies demonstrating
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130422627
--- Diff:
examples/storm-kafka-client-examples/src/main/java/org/apache/storm/kafka/trident/TridentKafkaClientWordCountNamedTopics.java
---
@@ -42,72 +42,68
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130352763
--- Diff: examples/storm-kafka-client-examples/README.markdown ---
@@ -0,0 +1,10 @@
+## Usage
+This module contains example topologies demonstrating
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130255082
--- Diff: examples/storm-kafka-client-examples/pom.xml ---
@@ -73,19 +75,27 @@
org.apache.storm
storm-kafka-client
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130255089
--- Diff: examples/storm-kafka-client-examples/pom.xml ---
@@ -73,19 +75,27 @@
org.apache.storm
storm-kafka-client
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130255066
--- Diff: examples/storm-kafka-client-examples/pom.xml ---
@@ -42,7 +42,9 @@
org.apache.storm
storm-kafka
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130254961
--- Diff: examples/storm-kafka-client-examples/README.markdown ---
@@ -0,0 +1,10 @@
+## Usage
+This module contains example topologies
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2243#discussion_r130255074
--- Diff: examples/storm-kafka-client-examples/pom.xml ---
@@ -73,19 +75,27 @@
org.apache.storm
storm-kafka-client
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2243
STORM-2658: Extract storm-kafka-client examples to storm-kafka-clientâ¦
â¦-examples, make storm-kafka-client-examples generate a jar with all
dependencies.
See
23 matches
Mail list logo
