[GitHub] storm pull request #2443: ISSUE-2406 [Storm SQL] Change underlying API to St...

2017-12-04 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2443#discussion_r154632607 --- Diff: sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/rel/StreamsStreamInsertRel.java --- @@ -27,50 +30,46 @@ import org.apache

[GitHub] storm pull request #2443: ISSUE-2406 [Storm SQL] Change underlying API to St...

2017-12-04 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2443#discussion_r154631668 --- Diff: sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/rel/StreamsStreamInsertRel.java --- @@ -27,50 +30,46 @@ import org.apache

[GitHub] storm pull request #2443: ISSUE-2406 [Storm SQL] Change underlying API to St...

2017-12-04 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2443 ISSUE-2406 [Storm SQL] Change underlying API to Streams API * This will enable us to provide windowed aggregation, join, etc later. * Tuple-to-tuple is making more sense than micro-batch in