Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2633
---
Github user ghajos commented on a diff in the pull request:
https://github.com/apache/storm/pull/2633#discussion_r188606821
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HdfsSpout.java ---
@@ -221,14 +221,18 @@ public void nextTuple() {
while
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2633#discussion_r188594538
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HdfsSpout.java ---
@@ -221,14 +221,18 @@ public void nextTuple() {
while
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2633#discussion_r184707886
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HdfsSpout.java ---
@@ -101,6 +101,7 @@
private final AtomicBoolean
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2633#discussion_r184711553
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java
---
@@ -153,6 +153,35 @@ public void testSimpleText_ACK() throws
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2633#discussion_r184710659
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java
---
@@ -153,6 +153,35 @@ public void testSimpleText_ACK() throws
GitHub user ghajos opened a pull request:
https://github.com/apache/storm/pull/2633
STORM-3028 HdfsSpout: handle empty file in case of ackers
There is a problem with all the storm-hdfs junit tests. The test results
may not be valid.
You can merge this pull request into a Git
