[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2687 ---

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190294254 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190287991 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190183265 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190175640 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-22 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190067973 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-22 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190059863 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-22 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2687 STORM-3061: thrift 0.11 This moves to thrift 0.11 The only files changed are pom.xml and genthrift.sh. The other files are all generated. You can merge this pull request into a Git