[GitHub] storm pull request #2726: STORM-3090 - Fix bug when different topics use the...

2018-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2726 ---

[GitHub] storm pull request #2726: STORM-3090 - Fix bug when different topics use the...

2018-07-06 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2726#discussion_r200657323 --- Diff: external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java --- @@ -140,6 +140,42 @@ public void testPartitionManagerRecreate()

[GitHub] storm pull request #2726: STORM-3090 - Fix bug when different topics use the...

2018-07-06 Thread choojoyq
Github user choojoyq commented on a diff in the pull request: https://github.com/apache/storm/pull/2726#discussion_r200655178 --- Diff: external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java --- @@ -140,6 +140,42 @@ public void testPartitionManagerRecreate()

[GitHub] storm pull request #2726: STORM-3090 - Fix bug when different topics use the...

2018-07-06 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2726#discussion_r200653436 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java --- @@ -107,14 +110,14 @@ public void refresh() {

[GitHub] storm pull request #2726: STORM-3090 - Fix bug when different topics use the...

2018-07-06 Thread choojoyq
Github user choojoyq commented on a diff in the pull request: https://github.com/apache/storm/pull/2726#discussion_r200651516 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java --- @@ -107,14 +110,14 @@ public void refresh() {

[GitHub] storm pull request #2726: STORM-3090 - Fix bug when different topics use the...

2018-07-05 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2726#discussion_r200456835 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java --- @@ -107,14 +110,14 @@ public void refresh() {

[GitHub] storm pull request #2726: STORM-3090 - Fix bug when different topics use the...

2018-07-05 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2726#discussion_r200456703 --- Diff: external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java --- @@ -140,6 +140,42 @@ public void testPartitionManagerRecreate()

[GitHub] storm pull request #2726: STORM-3090 - Fix bug when different topics use the...

2018-06-19 Thread choojoyq
GitHub user choojoyq opened a pull request: https://github.com/apache/storm/pull/2726 STORM-3090 - Fix bug when different topics use the same offset for a partition In the current implementation of `ZkCoordinator` deleted partition managers are used as state holders for newly