[GitHub] storm pull request #2735: STORM-3121: Fix flaky metrics tests in storm-core

2018-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2735 ---

[GitHub] storm pull request #2735: STORM-3121: Fix flaky metrics tests in storm-core

2018-06-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2735#discussion_r198022430 --- Diff: storm-core/pom.xml --- @@ -184,6 +184,10 @@ mockito-core test + +

[GitHub] storm pull request #2735: STORM-3121: Fix flaky metrics tests in storm-core

2018-06-25 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2735#discussion_r197962370 --- Diff: storm-core/pom.xml --- @@ -184,6 +184,10 @@ mockito-core test + +

[GitHub] storm pull request #2735: STORM-3121: Fix flaky metrics tests in storm-core

2018-06-25 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2735#discussion_r197856967 --- Diff: storm-core/pom.xml --- @@ -184,6 +184,10 @@ mockito-core test + +

[GitHub] storm pull request #2735: STORM-3121: Fix flaky metrics tests in storm-core

2018-06-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2735#discussion_r197838595 --- Diff: storm-core/pom.xml --- @@ -184,6 +184,10 @@ mockito-core test + +

[GitHub] storm pull request #2735: STORM-3121: Fix flaky metrics tests in storm-core

2018-06-24 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2735#discussion_r197654356 --- Diff: storm-core/test/clj/org/apache/storm/metrics_test.clj --- @@ -87,12 +91,22 @@ (first) ;; pick first task in the list, ignore other

[GitHub] storm pull request #2735: STORM-3121: Fix flaky metrics tests in storm-core

2018-06-24 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2735#discussion_r197652249 --- Diff: storm-core/test/clj/org/apache/storm/metrics_test.clj --- @@ -87,12 +91,22 @@ (first) ;; pick first task in the list, ignore other tasks'

[GitHub] storm pull request #2735: STORM-3121: Fix flaky metrics tests in storm-core

2018-06-24 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2735#discussion_r197651740 --- Diff: storm-core/test/clj/org/apache/storm/metrics_test.clj --- @@ -87,12 +91,22 @@ (first) ;; pick first task in the list, ignore other

[GitHub] storm pull request #2735: STORM-3121: Fix flaky metrics tests in storm-core

2018-06-24 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2735 STORM-3121: Fix flaky metrics tests in storm-core https://issues.apache.org/jira/browse/STORM-3121 You can merge this pull request into a Git repository by running: $ git pull