[GitHub] storm pull request #2739: [STORM-3125/3126/3127]: Refactoring components for...

2018-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2739 ---

[GitHub] storm pull request #2739: [STORM-3125/3126/3127]: Refactoring components for...

2018-06-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2739#discussion_r198983226 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedBlob.java --- @@ -59,57 +59,47 @@ protected LocallyCachedBlob(String

[GitHub] storm pull request #2739: [STORM-3125/3126/3127]: Refactoring components for...

2018-06-28 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2739#discussion_r198980565 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedBlob.java --- @@ -59,57 +59,47 @@ protected LocallyCachedBlob(String

[GitHub] storm pull request #2739: [STORM-3125/3126/3127]: Refactoring components for...

2018-06-28 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2739#discussion_r198977745 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java --- @@ -241,64 +255,54 @@ static DynamicState

[GitHub] storm pull request #2739: [STORM-3125/3126/3127]: Refactoring components for...

2018-06-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2739#discussion_r198900160 --- Diff: storm-server/src/main/java/org/apache/storm/utils/EnumUtil.java --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2739: [STORM-3125/3126/3127]: Refactoring components for...

2018-06-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2739#discussion_r198900030 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedBlob.java --- @@ -162,6 +152,31 @@ protected static long getSizeOnDisk(Path p)

[GitHub] storm pull request #2739: [STORM-3125/3126/3127]: Refactoring components for...

2018-06-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2739#discussion_r198899945 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedBlob.java --- @@ -59,57 +59,47 @@ protected LocallyCachedBlob(String