[GitHub] storm pull request #2746: STORM-3136: Fix flaky integration test, clean up t...

2018-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2746 ---

[GitHub] storm pull request #2746: STORM-3136: Fix flaky integration test, clean up t...

2018-07-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2746#discussion_r201149188 --- Diff: integration-test/src/main/java/org/apache/storm/st/topology/window/TimeDataIncrementingSpout.java --- @@ -0,0 +1,64 @@ +/* + * Copyright

[GitHub] storm pull request #2746: STORM-3136: Fix flaky integration test, clean up t...

2018-07-09 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2746#discussion_r201144238 --- Diff: integration-test/src/main/java/org/apache/storm/st/topology/window/TimeDataIncrementingSpout.java --- @@ -0,0 +1,64 @@ +/* + *

[GitHub] storm pull request #2746: STORM-3136: Fix flaky integration test, clean up t...

2018-06-29 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2746 STORM-3136: Fix flaky integration test, clean up that code to be more… … readable https://issues.apache.org/jira/browse/STORM-3136 * Deduplicated the test spouts and bolts a bit.