[GitHub] storm pull request #2755: STORM-3082 Add support to handle absent topics

2018-07-09 Thread aniketalhat
Github user aniketalhat closed the pull request at: https://github.com/apache/storm/pull/2755 ---

[GitHub] storm pull request #2755: STORM-3082 Add support to handle absent topics

2018-07-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2755#discussion_r200959509 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedTopicFilter.java --- @@ -54,8 +57,12 @@ public

[GitHub] storm pull request #2755: STORM-3082 Add support to handle absent topics

2018-07-08 Thread aniketalhat
Github user aniketalhat commented on a diff in the pull request: https://github.com/apache/storm/pull/2755#discussion_r200866147 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedTopicFilter.java --- @@ -54,8 +57,12 @@ public

[GitHub] storm pull request #2755: STORM-3082 Add support to handle absent topics

2018-07-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2755#discussion_r200803766 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedTopicFilter.java --- @@ -54,8 +57,12 @@ public

[GitHub] storm pull request #2755: STORM-3082 Add support to handle absent topics

2018-07-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2755#discussion_r200803791 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/NamedTopicFilterTest.java --- @@ -63,6 +63,20 @@ public void testFilter() {

[GitHub] storm pull request #2755: STORM-3082 Add support to handle absent topics

2018-07-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2755#discussion_r200803795 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicPartitionConnections.java --- @@ -57,6 +57,7 @@ public SimpleConsumer register(Partition

[GitHub] storm pull request #2755: STORM-3082 Add support to handle absent topics

2018-07-06 Thread aniketalhat
Github user aniketalhat commented on a diff in the pull request: https://github.com/apache/storm/pull/2755#discussion_r200802071 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicPartitionConnections.java --- @@ -57,6 +57,7 @@ public SimpleConsumer