[GitHub] storm pull request #2778: (1.x) STORM-3121: Fix flaky metrics tests in storm...

2018-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2778 ---

[GitHub] storm pull request #2778: (1.x) STORM-3121: Fix flaky metrics tests in storm...

2018-07-29 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2778#discussion_r205965687 --- Diff: storm-core/test/resources/log4j2-test.xml --- @@ -25,7 +25,8 @@ - + --- End di

[GitHub] storm pull request #2778: (1.x) STORM-3121: Fix flaky metrics tests in storm...

2018-07-29 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2778#discussion_r205965554 --- Diff: storm-core/test/resources/log4j2-test.xml --- @@ -25,7 +25,8 @@ - + --- End diff --

[GitHub] storm pull request #2778: (1.x) STORM-3121: Fix flaky metrics tests in storm...

2018-07-29 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2778#discussion_r205964723 --- Diff: storm-core/test/clj/org/apache/storm/metrics_test.clj --- @@ -15,16 +15,14 @@ ;; limitations under the License. (ns org.apache.storm.m

[GitHub] storm pull request #2778: (1.x) STORM-3121: Fix flaky metrics tests in storm...

2018-07-29 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2778 (1.x) STORM-3121: Fix flaky metrics tests in storm-core This ports back #2735 to 1.x-branch since I can see flaky metrics tests from 1.x-branch. https://travis-ci.org/apache/storm/jobs/