[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2788 ---

[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-03 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2788#discussion_r207587787 --- Diff: storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java --- @@ -0,0 +1,29 @@ +/** + *

[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-03 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2788#discussion_r207587402 --- Diff: storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java --- @@ -0,0 +1,29 @@ +/** + *

[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-03 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2788#discussion_r207586437 --- Diff: storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java --- @@ -0,0 +1,29 @@ +/** + *

[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2788#discussion_r207539609 --- Diff: storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java --- @@ -0,0 +1,29 @@ +/** + *

[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-02 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2788#discussion_r207376890 --- Diff: storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java --- @@ -133,10 +123,15 @@ public int compare(File f1,

[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-02 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2788#discussion_r207328701 --- Diff: storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java --- @@ -0,0 +1,29 @@ +/** + *

[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-02 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2788#discussion_r207327774 --- Diff: storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java --- @@ -0,0 +1,29 @@ +/** + *

[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-02 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2788#discussion_r207327029 --- Diff: storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java --- @@ -133,10 +123,15 @@ public int compare(File f1, File

[GitHub] storm pull request #2788: STORM-3170: Fixed bug to eliminate invalid file de...

2018-08-01 Thread zd-project
GitHub user zd-project opened a pull request: https://github.com/apache/storm/pull/2788 STORM-3170: Fixed bug to eliminate invalid file deletion https://issues.apache.org/jira/browse/STORM-3170 You can merge this pull request into a Git repository by running: $ git pull