[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-11 Thread govind-menon
Github user govind-menon commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r247197760 --- Diff: bin/storm.py --- @@ -296,787 +239,1044 @@ def exec_storm_class(klass, jvmtype="-server", jvmopts=[], extrajars=[], args=[] elif is_wi

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245727413 --- Diff: bin/storm.py --- @@ -296,787 +239,1044 @@ def exec_storm_class(klass, jvmtype="-server", jvmopts=[], extrajars=[], args=[] elif is_windows():

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245744213 --- Diff: bin/storm.py --- @@ -296,787 +239,1044 @@ def exec_storm_class(klass, jvmtype="-server", jvmopts=[], extrajars=[], args=[] elif is_windows():

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread govind-menon
Github user govind-menon commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245726485 --- Diff: storm-client/pom.xml --- @@ -240,6 +240,29 @@ + +

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245725371 --- Diff: storm-client/pom.xml --- @@ -240,6 +240,29 @@ + +org.

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245722204 --- Diff: bin/storm.py --- @@ -296,787 +239,1044 @@ def exec_storm_class(klass, jvmtype="-server", jvmopts=[], extrajars=[], args=[] elif is_windows():

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245714702 --- Diff: bin/storm.py --- @@ -132,13 +56,8 @@ def get_jars_full(adir): elif os.path.exists(adir): files = [adir] -ret = []

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245715647 --- Diff: bin/storm.py --- @@ -156,49 +95,92 @@ def get_classpath(extrajars, daemon=True, client=False): ret.extend(get_wildcard_dir(os.path.join(STORM

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread govind-menon
Github user govind-menon commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245709584 --- Diff: storm-client/pom.xml --- @@ -240,6 +240,29 @@ + +

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245602260 --- Diff: storm-client/pom.xml --- @@ -240,6 +240,29 @@ + +org.

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-05 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245480567 --- Diff: storm-client/pom.xml --- @@ -240,6 +240,29 @@ + +org.

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2018-12-26 Thread govind-menon
GitHub user govind-menon opened a pull request: https://github.com/apache/storm/pull/2930 STORM-3274: Migrates storm CLI to using argparse making documentation… … more accessible You can merge this pull request into a Git repository by running: $ git pull https://github.com