Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-10 Thread via GitHub
rzo1 commented on PR #3526: URL: https://github.com/apache/storm/pull/3526#issuecomment-1673071586 Short update on kryo5 (lib variant): We can not simply switch because of packaging changes impacting carbonite and chill-java (method signatures won't match), so not a thing as of today to

Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-09 Thread via GitHub
bipinprasad commented on PR #3526: URL: https://github.com/apache/storm/pull/3526#issuecomment-1671733875 Thanks. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-09 Thread via GitHub
bipinprasad merged PR #3526: URL: https://github.com/apache/storm/pull/3526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-09 Thread via GitHub
rzo1 commented on PR #3526: URL: https://github.com/apache/storm/pull/3526#issuecomment-1671693360 I cleaned it up, so we are mergable again. However, I want to check if we better use the kyro5 artifact as shade replacement: https://groups.google.com/g/kryo-users/c/hVlwHmBE_-s