Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)

2023-11-09 Thread via GitHub
rzo1 closed pull request #3554: [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… URL: https://github.com/apache/storm/pull/3554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)

2023-11-09 Thread via GitHub
rzo1 commented on PR #3554: URL: https://github.com/apache/storm/pull/3554#issuecomment-1803772348 IDE reports, that this exception isn't thrown at the place the catch block was added. I am closing this PR now. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)

2023-10-23 Thread via GitHub
rzo1 commented on PR #3554: URL: https://github.com/apache/storm/pull/3554#issuecomment-1775692654 @LoggingResearch any updates on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)

2023-08-10 Thread via GitHub
rzo1 commented on code in PR #3554: URL: https://github.com/apache/storm/pull/3554#discussion_r1290048620 ## storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java: ## Review Comment: Exception needs to be removed from `throws` -- This is an

Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)

2023-08-07 Thread via GitHub
rzo1 commented on PR #3554: URL: https://github.com/apache/storm/pull/3554#issuecomment-1667646679 Can you rebase @LoggingResearch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific