Re: [CANCELED] [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-26 Thread P. Taylor Goetz
Sure, no problem. -Taylor > On Jul 26, 2017, at 3:45 PM, Stig Rohde Døssing > wrote: > > Taylor can you wait 2-3 minutes, I'd like to merge > https://github.com/apache/storm/pull/2244 in if you're making a new RC > anyway? > > 2017-07-26 21:34 GMT+02:00 P. Taylor

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-26 Thread Stig Rohde Døssing
Taylor can you wait 2-3 minutes, I'd like to merge https://github.com/apache/storm/pull/2244 in if you're making a new RC anyway? 2017-07-26 21:34 GMT+02:00 P. Taylor Goetz : > Canceling per discussion. > > -Taylor > > > On Jul 25, 2017, at 11:09 AM, P. Taylor Goetz

[CANCELED] [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-26 Thread P. Taylor Goetz
Canceling per discussion. -Taylor > On Jul 25, 2017, at 11:09 AM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.1.1 (rc1) > > Full list of changes in this release: > >

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-26 Thread P. Taylor Goetz
Fair enough. I’ll apply the patches I have in mind to 1.1.x-branch and spin up a new release candidate. -Taylor > On Jul 26, 2017, at 2:24 AM, Jungtaek Lim wrote: > > Replying inline. My only concern is about semantic versioning. If we don't > change the version of

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-26 Thread Jungtaek Lim
Replying inline. My only concern is about semantic versioning. If we don't change the version of 1.x-branch and call this RC as 1.2.0 I would not have any concerns. Thanks, Jungtaek Lim (HeartSaVioR) 2017년 7월 26일 (수) 오전 9:55, P. Taylor Goetz 님이 작성: > > > On Jul 25, 2017, at

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread P. Taylor Goetz
> On Jul 25, 2017, at 6:36 PM, Jungtaek Lim wrote: > > I believe I ported back complete set of bugfixes to the 1.1.x-branch when I > created 1.1.x-branch. > > 1.x-branch has some new features after 1.1.0, even also has backward > incompatible change: Redis state changed to

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread Jungtaek Lim
I believe I ported back complete set of bugfixes to the 1.1.x-branch when I created 1.1.x-branch. 1.x-branch has some new features after 1.1.0, even also has backward incompatible change: Redis state changed to binary. I included migration script on it but still don't think it is bugfix. Taylor,

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread Stig Rohde Døssing
I ran into https://issues.apache.org/jira/browse/STORM-2659, which is a regression compared to 1.0.x, but not compared to 1.1.0. I think it would be nice to get fixed. 2017-07-25 20:59 GMT+02:00 Bobby Evans : > We could do a 1.1.2 release sooner if needed.

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread Bobby Evans
We could do a 1.1.2 release sooner if needed.  Technically any committer can call for a release at any point in time.  If there is a reason to do a release (like an important fix for a critical component) then we can do it. - Bobby On Tuesday, July 25, 2017, 1:48:07 PM CDT, Alexandre

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread Alexandre Vermeerbergen
Hi, I guess 1.1.2 is going to be a few months away from now, so we'll have to go with our own basic Kafka 0.10 Spout in the meantime... You can discard my previous vote, we'd need to at least download 1.1.1 rc and give it a try to make an objective vote. Regards, Alexandre Vermeerbergen

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread P. Taylor Goetz
Hi Alexandre, STORM-2648 couldn’t be included because there is no patch available for it yet. Once there is a patch available, it can go into the next release, so it’s certainly possible for it to be available in 1.1.2. -Taylor > On Jul 25, 2017, at 1:12 PM, Alexandre Vermeerbergen >

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread Harsha
Tested source code by running unit tests and installed binaries to run example topologies. +1. -Harsha On Tue, Jul 25, 2017, at 10:08 AM, Bobby Evans wrote: > I built from source (v1.1.1 88f0b8a45553ea960164fab18c736a5cdbae8e58) ran > all of the unit tests and ran some manual tests. > I am +1 on

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread Bobby Evans
I built from source (v1.1.1 88f0b8a45553ea960164fab18c736a5cdbae8e58) ran all of the unit tests and ran some manual tests. I am +1 on the release. - Bobby On Tuesday, July 25, 2017, 11:14:14 AM CDT, Kishorkumar Patil wrote: I built and ran some manual tests.

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread Alexandre Vermeerbergen
Hello, -1 (non binding) Maybe it's a bit selfish, but I really count on https://issues.apache.org/jira/browse/STORM-2648 being part of Storm 1.1.1, because we have a requirement to use Kafka 0.10 consumer in topologies requiring at most once behavior. We understood that we could use

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread P. Taylor Goetz
Yes. There were a number of important patches present in 1.x-branch that were not in 1.1.x-branch. When I tried to merge 1.x-branch to 1.1.x-branch, I ran into unexpected conflicts. I thought about deleting 1.1.x-branch and recreating it, but decided against it, not wanting lose changes there

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread Kishorkumar Patil
I built and ran some manual tests. +1 to release this package. -Kishor On Tuesday, July 25, 2017, 12:08:32 PM EDT, Stig Rohde Døssing wrote: Is it on purpose that this is cut from 1.x-branch and not 1.1.x-branch? 2017-07-25 17:09 GMT+02:00 P. Taylor Goetz

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread Stig Rohde Døssing
Is it on purpose that this is cut from 1.x-branch and not 1.1.x-branch? 2017-07-25 17:09 GMT+02:00 P. Taylor Goetz : > This is a call to vote on releasing Apache Storm 1.1.1 (rc1) > > Full list of changes in this release: > >

[VOTE] Release Apache Storm 1.1.1 (rc1)

2017-07-25 Thread P. Taylor Goetz
This is a call to vote on releasing Apache Storm 1.1.1 (rc1) Full list of changes in this release: https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;hb=88f0b8a45553ea960164fab18c736a5cdbae8e58 The tag/commit to be voted upon is v1.1.1: