[GitHub] stratos pull request: Cleaning and Formatting Code

2015-08-10 Thread rekathiru
Github user rekathiru commented on the pull request: https://github.com/apache/stratos/pull/420#issuecomment-129382653 Sorry for the noise..There was a NULL check already added in the code. So no need of doing it.. --- If your project is set up for it, you can reply to this email

[GitHub] stratos pull request: Cleaning and Formatting Code

2015-08-10 Thread rekathiru
Github user rekathiru commented on the pull request: https://github.com/apache/stratos/pull/420#issuecomment-129368585 Hi Thanuja, Please add the application null check to the if condition. Otherwise there could be a possibility for NPE in the following if condition

[GitHub] stratos pull request: Group validation for deployment policies def...

2015-06-18 Thread rekathiru
Github user rekathiru commented on the pull request: https://github.com/apache/stratos/pull/371#issuecomment-113104689 Can you use different variable in validateGroupsRecursively for hasDP when you assign value to this variable inside the method? Otherwise this variable will get

[GitHub] stratos pull request: Adding more information to scaleup and scale...

2015-05-14 Thread rekathiru
Github user rekathiru commented on the pull request: https://github.com/apache/stratos/pull/317#issuecomment-102048802 Hi Vishanth, Can you include application-id, cluster-instance-id and network-partition-id also to these logs? So that it will be more descriptive.. --- If your