Re: [Discuss] [Question] AutoscalerUtil.allClustersInitialized() Method

2015-02-08 Thread Reka Thirunavukkarasu
Sorry. I should have added the comment in that section. Will go through the code and add the relevant comments in the area where it has less visibility. Thanks, Reka On Sat, Feb 7, 2015 at 11:23 AM, Reka Thirunavukkarasu wrote: > Hi Imesh, > > As i explained in the other thread, all the cluster

Re: [Discuss] [Question] AutoscalerUtil.allClustersInitialized() Method

2015-02-08 Thread Reka Thirunavukkarasu
Hi Imesh, As i explained in the other thread, all the clusters are created at once in the ApplicationClustersCreatedEvent. I beleive that by checking whether one of the cluster exists, we can assume that all the clusters are there which will improve performance as well. Thanks, Reka On Sat, Feb

Re: [Discuss] [Question] AutoscalerUtil.allClustersInitialized() Method

2015-02-08 Thread Imesh Gunaratne
Great thanks Reka! Now it looks good. On Sun, Feb 8, 2015 at 12:03 AM, Reka Thirunavukkarasu wrote: > Added comment in 0b409e5cd2020322b82a9c472a9cee6d4c3e607f. > > On Sat, Feb 7, 2015 at 11:26 AM, Reka Thirunavukkarasu > wrote: > >> Sorry. I should have added the comment in that section. Will

Re: [Discuss] [Question] AutoscalerUtil.allClustersInitialized() Method

2015-02-08 Thread Reka Thirunavukkarasu
+1. Will include comments for such code segment.. Thanks, Reka On Sat, Feb 7, 2015 at 6:43 PM, Imesh Gunaratne wrote: > As I found we have written above logic to check availability of one > cluster and assume that all the other clusters have been initialized > because of the Application Cluster

Re: [Discuss] [Question] AutoscalerUtil.allClustersInitialized() Method

2015-02-08 Thread Reka Thirunavukkarasu
Added comment in 0b409e5cd2020322b82a9c472a9cee6d4c3e607f. On Sat, Feb 7, 2015 at 11:26 AM, Reka Thirunavukkarasu wrote: > Sorry. I should have added the comment in that section. Will go through > the code and add the relevant comments in the area where it has less > visibility. > > Thanks, > Re

Re: [Discuss] [Question] AutoscalerUtil.allClustersInitialized() Method

2015-02-07 Thread Imesh Gunaratne
As I found we have written above logic to check availability of one cluster and assume that all the other clusters have been initialized because of the Application Clusters created event. IMO if we are writing such logic we need to add some comments describing the assumptions. Otherwise it would b

[Discuss] [Question] AutoscalerUtil.allClustersInitialized() Method

2015-02-07 Thread Imesh Gunaratne
Hi Reka, Would you mind explaining the logic in this method? It is difficult to understand the statements highlighted in yellow. If we are trying to check whether all clusters have been initialized in an application, why do we return true if one of the service clusters exists? public static boole