[GitHub] stratos pull request: Adding network partitions for CLI

2015-05-25 Thread prabathabey
Github user prabathabey commented on a diff in the pull request: https://github.com/apache/stratos/pull/198#discussion_r31002645 --- Diff: components/org.apache.stratos.cli/src/main/java/org/apache/stratos/cli/RestCommandLineService.java --- @@ -293,44 +297,44 @@ public void listC

[GitHub] stratos pull request: Adding network partitions for CLI (UpdateNet...

2015-02-05 Thread dinithis
Github user dinithis closed the pull request at: https://github.com/apache/stratos/pull/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] stratos pull request: Adding network partitions for CLI (UpdateNet...

2015-02-04 Thread imesh
Github user imesh commented on the pull request: https://github.com/apache/stratos/pull/203#issuecomment-72989003 @dinithis There are some merge conflicts in this pull request, can you please resolve them? CONFLICT (add/add): Merge conflict in components/org.apache.strato

[GitHub] stratos pull request: Adding network partitions for CLI (UpdateNet...

2015-02-02 Thread dinithis
GitHub user dinithis opened a pull request: https://github.com/apache/stratos/pull/203 Adding network partitions for CLI (UpdateNetworkPartition) Adding network partitions for CLI (UpdateNetworkPartition) You can merge this pull request into a Git repository by running: $ git p

[GitHub] stratos pull request: Adding network partitions for CLI

2015-01-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/stratos/pull/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] stratos pull request: Adding network partitions for CLI

2015-01-29 Thread dinithis
Github user dinithis commented on the pull request: https://github.com/apache/stratos/pull/198#issuecomment-72154787 Adding network partitions for CLI - changed suggested modifications --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] stratos pull request: Adding network partitions for CLI

2015-01-29 Thread swgkg
Github user swgkg commented on a diff in the pull request: https://github.com/apache/stratos/pull/198#discussion_r23768119 --- Diff: components/org.apache.stratos.cli/src/main/java/org/apache/stratos/cli/RestCommandLineService.java --- @@ -1130,4 +1134,57 @@ private void printErro

[GitHub] stratos pull request: Adding network partitions for CLI

2015-01-29 Thread swgkg
Github user swgkg commented on a diff in the pull request: https://github.com/apache/stratos/pull/198#discussion_r23767029 --- Diff: components/org.apache.stratos.cli/src/main/java/org/apache/stratos/cli/commands/AddNetworkPartitionCommand.java --- @@ -0,0 +1,174 @@ +/** +

[GitHub] stratos pull request: Adding network partitions for CLI

2015-01-29 Thread imesh
Github user imesh commented on the pull request: https://github.com/apache/stratos/pull/198#issuecomment-72022527 Overall this pull request looks good, however I can see considerable amount of code formattings. It would be better to do code formatting in a different pull request as it

[GitHub] stratos pull request: Adding network partitions for CLI

2015-01-29 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/198#discussion_r23766401 --- Diff: components/org.apache.stratos.cli/src/main/java/org/apache/stratos/cli/RestCommandLineService.java --- @@ -1130,4 +1134,57 @@ private void printErro

[GitHub] stratos pull request: Adding network partitions for CLI

2015-01-29 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/198#discussion_r23766317 --- Diff: components/org.apache.stratos.cli/src/main/java/org/apache/stratos/cli/commands/AddNetworkPartitionCommand.java --- @@ -0,0 +1,174 @@ +/** +

[GitHub] stratos pull request: Adding network partitions for CLI

2015-01-29 Thread dinithis
GitHub user dinithis opened a pull request: https://github.com/apache/stratos/pull/198 Adding network partitions for CLI Adding network partitions for CLI You can merge this pull request into a Git repository by running: $ git pull https://github.com/dinithis/stratos master Al