Re: [IMPORTANT] Tips for new committers

2015-09-12 Thread Imesh Gunaratne
On Fri, Sep 11, 2015 at 2:02 PM, Akila Ravihansa Perera wrote: > Hi all, > > Thanks for the feedback! > > I've created a Gdoc with what we discussed [1]. I'd like to propose that > all committers create PRs for major features they are doing and some other > committer review and merge them. But

Re: [IMPORTANT] Tips for new committers

2015-09-11 Thread Isuru Perera
On Fri, Sep 11, 2015 at 3:32 PM, Lakmal Warusawithana wrote: > > > On Fri, Sep 11, 2015 at 2:02 PM, Akila Ravihansa Perera < > raviha...@wso2.com> wrote: > >> Hi all, >> >> Thanks for the feedback! >> >> I've created a Gdoc with what we discussed [1]. I'd like to propose that >> all committers c

Re: [IMPORTANT] Tips for new committers

2015-09-11 Thread Lakmal Warusawithana
On Fri, Sep 11, 2015 at 2:02 PM, Akila Ravihansa Perera wrote: > Hi all, > > Thanks for the feedback! > > I've created a Gdoc with what we discussed [1]. I'd like to propose that > all committers create PRs for major features they are doing and some other > committer review and merge them. But s

Re: [IMPORTANT] Tips for new committers

2015-09-11 Thread Akila Ravihansa Perera
Hi all, Thanks for the feedback! I've created a Gdoc with what we discussed [1]. I'd like to propose that all committers create PRs for major features they are doing and some other committer review and merge them. But small bug fixes and minor features can be merged directly. wdyt? @Lakmal: Let

Re: [IMPORTANT] Tips for new committers

2015-09-11 Thread Sajith Kariyawasam
Great tips Akila! I would like to include 'running sonar' before committing the code. +1 for adding these to wiki. On Fri, Sep 11, 2015 at 12:37 PM, Isuru Perera wrote: > Hi Akila, > > These are good tips! I have seen many build unstable mails recently (I > didn't go through each of those). It

Re: [IMPORTANT] Tips for new committers

2015-09-11 Thread Isuru Perera
Hi Akila, These are good tips! I have seen many build unstable mails recently (I didn't go through each of those). It's always better to avoid build breaks. +1 for adding these tips to wiki. Thanks! Best Regards, On Fri, Sep 11, 2015 at 10:46 AM, Lakmal Warusawithana wrote: > Hi Akila, > > S

Re: [IMPORTANT] Tips for new committers

2015-09-10 Thread Lakmal Warusawithana
Hi Akila, Shall we add these into our wiki? thanks On Fri, Sep 11, 2015 at 2:59 AM, Akila Ravihansa Perera wrote: > Hi Devs, > > Thought of sharing this since we have some new committers. These are some > guidelines that I think we can adopt in Stratos project. This is only my > personal view,

Re: [IMPORTANT] Tips for new committers

2015-09-10 Thread Dinithi De Silva
Hi Akila, Thank you for the information. These is really helpful. On Fri, Sep 11, 2015 at 2:59 AM, Akila Ravihansa Perera wrote: > Hi Devs, > > Thought of sharing this since we have some new committers. These are some > guidelines that I think we can adopt in Stratos project. This is only my >

[IMPORTANT] Tips for new committers

2015-09-10 Thread Akila Ravihansa Perera
Hi Devs, Thought of sharing this since we have some new committers. These are some guidelines that I think we can adopt in Stratos project. This is only my personal view, and open to discussion :) 1. Always create a branch in your fork when developing a feature or fixing a bug. We tend to forget