Re: Clean script kills all java processes

2014-10-22 Thread Imesh Gunaratne
Great! Thanks Chamila. On Mon, Oct 20, 2014 at 1:11 PM, Chamila De Alwis wrote: > Hi Imesh, > > Thanks for the improvement suggestion. This is possible to do since > ActiveMQ has its pid stored in a pid file inside the data directory. We can > store that and the pid's from the Carbon servers. I

[GitHub] stratos pull request: Clean script kills all Java processes.

2014-10-21 Thread chamilad
Github user chamilad commented on the pull request: https://github.com/apache/stratos/pull/93#issuecomment-60042465 @imesh Thanks for the suggestion. This is possible to do since ActiveMQ has its pid stored in a pid file inside the data directory. We can store that and the p

Re: Clean script kills all java processes

2014-10-20 Thread Chamila De Alwis
Hi Imesh, Thanks for the improvement suggestion. This is possible to do since ActiveMQ has its pid stored in a pid file inside the data directory. We can store that and the pid's from the Carbon servers. I will come up with a PR soon. Regards, Chamila de Alwis Software Engineer | WSO2 | +9477220

[GitHub] stratos pull request: Clean script kills all Java processes.

2014-10-17 Thread imesh
Github user imesh commented on the pull request: https://github.com/apache/stratos/pull/93#issuecomment-59599713 Great work! I still think we can improve this further by keeping the process ids at the server startup and use them to execute the termination process. Otherwise there coul

Re: Clean script kills all java processes

2014-10-17 Thread Imesh Gunaratne
Hi Chamila, Great work, your approach seems to work but it would be better if we keep the process ids at the server startup and then use those to terminate. Otherwise there is a possibility that other Carbon servers or ActiveMQ instances running in the same host. Thanks. On Wed, Oct 15, 2014 at

Re: Clean script kills all java processes

2014-10-15 Thread Chamila De Alwis
Thanks Manula! Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Wed, Oct 15, 2014 at 9:09 PM, Manula Chathurika Thantriwatte < manu...@wso2.com> wrote: > Hi Chamila, > > +1 for the change. I have merged it. > > Thanks ! > > On Wed, Oct 15, 201

Re: Clean script kills all java processes

2014-10-15 Thread Manula Chathurika Thantriwatte
Hi Chamila, +1 for the change. I have merged it. Thanks ! On Wed, Oct 15, 2014 at 8:14 PM, Chamila De Alwis wrote: > Hi, > > The clean.sh script that is inside the tools/stratos-installer/ folder > kills all the Java related processes. Ideally the script should only stop > the Stratos processe

[GitHub] stratos pull request: Clean script kills all Java processes.

2014-10-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/stratos/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Clean script kills all java processes

2014-10-15 Thread Chamila De Alwis
Hi, The clean.sh script that is inside the tools/stratos-installer/ folder kills all the Java related processes. Ideally the script should only stop the Stratos processes and the ActiveMQ process. We can at least be specific to all the carbon related java processes. I created a fix for this and t

[GitHub] stratos pull request: Clean script kills all Java processes.

2014-10-15 Thread chamilad
GitHub user chamilad opened a pull request: https://github.com/apache/stratos/pull/93 Clean script kills all Java processes. This fix allows the clean script to filter the java processes by Carbon start string and ActiveMQ string You can merge this pull request into a Git