Re: Maintaining Better Coding Standards

2014-11-08 Thread Imesh Gunaratne
On Sat, Nov 8, 2014 at 11:14 PM, Udara Liyanage wrote: > Hi Imesh, > > Also in below methods entityName is used only for printing messages. We > can remove them, right? > No, this is how we have generalized CRUD operations and their error messages. Entity name is needed.

Re: Maintaining Better Coding Standards

2014-11-08 Thread Udara Liyanage
Hi Imesh, Also in below methods entityName is used only for printing messages. We can remove them, right? 1. public Object getEntity(String serviceEndpoint, Class responseJsonClass, String identifier, String entityName) { 2. try { 3. return executeGet(serviceEndp

Re: Maintaining Better Coding Standards

2014-11-08 Thread Imesh Gunaratne
I have now fixed this with commit revision: 414a93b7394de6eb3494f7d164e599006032ffcf On Sat, Nov 8, 2014 at 10:04 PM, Imesh Gunaratne wrote: > Hi, > > I noticed following domain classes introduced recently in the CLI: > > > ​ > It seems like the naming convention used in above classes Applicatio

Maintaining Better Coding Standards

2014-11-08 Thread Imesh Gunaratne
Hi, I noticed following domain classes introduced recently in the CLI: ​ It seems like the naming convention used in above classes Applications, Clusters, Groups and SubGroups is not correct. These classes look like collection types but they are single object types. Class: RestCommandLineServic