Re: REST API refactoring

2014-11-27 Thread Imesh Gunaratne
Great work Shiro! Thanks for looking into this. On Thu, Nov 27, 2014 at 3:48 PM, Shiroshica Kulatilake wrote: > Hi Devs, > > The REST API refactoring is now on master. (commits > 2242e2fc6083129e3f0e5b08707250f5b1648a44, > 023900c4fdd7ba9b12a228b5b

Re: REST API refactoring

2014-11-27 Thread Shiroshica Kulatilake
Hi Devs, The REST API refactoring is now on master. (commits 2242e2fc6083129e3f0e5b08707250f5b1648a44, 023900c4fdd7ba9b12a228b5bf619e77885a3f2f, 72c9d60433d9b196d67268e850e572fd81a9fd97, 6af9901141c9a89c44e76803b6cbdbb68561714c). The last commit consists of the changes that were required due to

Re: REST API refactoring

2014-11-25 Thread Imesh Gunaratne
Great work Shiro! On Tue, Nov 25, 2014 at 3:47 PM, Shiroshica Kulatilake wrote: > > 1. Do we need to expose the method *updateKubernetesHost(KubernetesHost > kubernetesHost)* via the REST api ? > IMO we need to check the reason for maintaining Kubernetes host information in Stratos. 2. The *g

Re: REST API refactoring

2014-11-25 Thread Shiroshica Kulatilake
It's there - no change to that method On Tue, Nov 25, 2014 at 4:11 PM, Dakshika Jayathilaka wrote: > Seems @GET "/groups" is missing here.. > > Regards, > > *Dakshika Jayathilaka* > Software Engineer > WSO2, Inc. > lean.enterprise.middleware > 0771100911 > > On Tue, Nov 25, 2014 at 3:47 PM,

Re: REST API refactoring

2014-11-25 Thread Dakshika Jayathilaka
Seems @GET "/groups" is missing here.. Regards, *Dakshika Jayathilaka* Software Engineer WSO2, Inc. lean.enterprise.middleware 0771100911 On Tue, Nov 25, 2014 at 3:47 PM, Shiroshica Kulatilake wrote: > Hi devs, > > I incorporated the refactoring done by Udara and also did a few more > modi

Re: REST API refactoring

2014-11-25 Thread Shiroshica Kulatilake
Hi devs, I incorporated the refactoring done by Udara and also did a few more modifications. diffs can be viewed at: 1. https://github.com/shirolk/stratos/commit/b2c16968242cd4b290764563119695e1ec504618 2. https://github.com/shirolk/stratos/commit/c45da1728465063e6c816f5f5763f8b5a6cc5415 There a

Re: REST API refactoring

2014-11-23 Thread Nirmal Fernando
Seems like none of the recent updates were synched. On Mon, Nov 24, 2014 at 6:37 AM, Shiroshica Kulatilake wrote: > Hi Udara, > > The branch which you created can only be seen in > https://git-wip-us.apache.org/repos/asf?p=stratos.git and not in > https://github.com/apache/stratos/ > > Would you

Re: REST API refactoring

2014-11-23 Thread Shiroshica Kulatilake
Hi Udara, The branch which you created can only be seen in https://git-wip-us.apache.org/repos/asf?p=stratos.git and not in https://github.com/apache/stratos/ Would you be able to please check what's missing. Thank you, Shiro On Sat, Nov 22, 2014 at 9:44 AM, Udara Liyanage wrote: > Hi, > > I

REST API refactoring

2014-11-21 Thread Udara Liyanage
Hi, I started refactoring Stratos REST API. In the process I have changed resource URLs so the API looks more RESTfull. I did not commit the changes to master branch since it will break UI and CLI. Instead I committed to a new branch "rest-api-refact" which you can work on re factoring work. --