Re: Redundant variables in init.sh

Created JIRA issue at https://issues.apache.org/jira/browse/STRATOS-749 and attached patch file. Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Mon, Aug 18, 2014 at 9:51 AM, Chamila De Alwis wrote: > .patch file attached. > > Hash of the c

Re: Redundant variables in init.sh

.patch file attached. Hash of the commit is f8e13a2 . Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Mon, Aug 18, 2014 at 9:46 AM, Chamila De Alwis wrote

Re: Redundant variables in init.sh

Yeah. I'll commit a patch soon. Thanks Dakshika for pointing out! Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Mon, Aug 18, 2014 at 8:35 AM, Dakshika Jayathilaka wrote: > seems this pull contain chef modifications as wel? > > *Dakshika J

Re: Redundant variables in init.sh

seems this pull contain chef modifications as wel? *Dakshika Jayathilaka* Software Engineer WSO2, Inc. lean.enterprise.middleware 0771100911 On Fri, Aug 15, 2014 at 2:17 AM, Chamila De Alwis wrote: > It seems I pasted the wrong link. Sorry! :) > > Please refer to this link [1] > > [1] - https:

Re: Redundant variables in init.sh

It seems I pasted the wrong link. Sorry! :) Please refer to this link [1] [1] - https://github.com/apache/stratos/pull/15 Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Thu, Aug 14, 2014 at 10:03 PM, Udara Liyanage wrote: > Hi Chamila, >

Re: Redundant variables in init.sh

Hi Chamila, Your link does not refer to a pull request. It refers to your Stratos folk. Folk Stratos repo Clone your folked repo Commit and push changes to your repo Send a pull request from your repo to Stratos repo Touched, not typed. Erroneous words are a feature, not a typo.

Re: Redundant variables in init.sh

Hi Udara, Did as requested. Please refer to the link.[1] [1] - https://github.com/chamilad/stratos.git Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Thu, Aug 14, 2014 at 4:59 PM, Udara Liyanage wrote: > Hi Chamila, > > Thank you very mu

Re: Redundant variables in init.sh

Hi Chamila, Thank you very much for your concern regarding the development of Stratos. Could you please send a pull request to Stratos. Your changes will be reviewed and merged. On Thu, Aug 14, 2014 at 4:35 PM, Chamila De Alwis wrote: > Hi, > > I was going through the init.sh script which is

Redundant variables in init.sh

Hi, I was going through the init.sh script which is run when an instance is spawned from a cartridge. Following variables seem to be unused after declaration. Line 38: PUPPETD=`which puppet` is declared and used subsequently in PUPPETAGENT and COMMAND. However when actually running the puppet age