Re: Stratos is not setting user meta data to instances created in GCE

2015-06-05 Thread Imesh Gunaratne
A great finding Asanka! Did we fix this for 4.1.0-RC3? On Wed, Jun 3, 2015 at 2:45 PM, Asanka Sanjaya Herath wrote: > OK. I'll send a pull request. > > On Wed, Jun 3, 2015 at 9:14 AM, Gayan Gunarathne wrote: > >> Great. We need to fix this in the master branch. Can you please send a PR >> for t

Re: Stratos is not setting user meta data to instances created in GCE

2015-06-03 Thread Asanka Sanjaya Herath
OK. I'll send a pull request. On Wed, Jun 3, 2015 at 9:14 AM, Gayan Gunarathne wrote: > Great. We need to fix this in the master branch. Can you please send a PR > for this? > > Thanks, > Gayan > > On Wed, Jun 3, 2015 at 2:31 PM, Asanka Sanjaya Herath > wrote: > >> Hi All, >> >> I removed the n

Re: Stratos is not setting user meta data to instances created in GCE

2015-06-03 Thread Gayan Gunarathne
Great. We need to fix this in the master branch. Can you please send a PR for this? Thanks, Gayan On Wed, Jun 3, 2015 at 2:31 PM, Asanka Sanjaya Herath wrote: > Hi All, > > I removed the null check and tested again. Now I can see the metadata has > set to the instance from the developers consol

Re: Stratos is not setting user meta data to instances created in GCE

2015-06-03 Thread Asanka Sanjaya Herath
Hi All, I removed the null check and tested again. Now I can see the metadata has set to the instance from the developers console. I have attached a screenshot here. Thanks for the help. On Wed, Jun 3, 2015 at 7:02 AM, Gayan Gunarathne wrote: > > > On Wed, Jun 3, 2015 at 12:00 PM, Isuru Haththo

Re: Stratos is not setting user meta data to instances created in GCE

2015-06-03 Thread Gayan Gunarathne
On Wed, Jun 3, 2015 at 12:00 PM, Isuru Haththotuwa wrote: > Did a quick check, seems the method [1] of IaaSConfig class is not getting > called from anywhere. The payload field in IaaSProvider is populated using > the same field in IaaSConfig. > Yeah.We are comparing wrong payload in the if cond

Re: Stratos is not setting user meta data to instances created in GCE

2015-06-02 Thread Isuru Haththotuwa
Did a quick check, seems the method [1] of IaaSConfig class is not getting called from anywhere. The payload field in IaaSProvider is populated using the same field in IaaSConfig. @ Asanka: Can you remove the null check [2] and re-test. [1].setPayload(byte[] payload) [2].iaasInfo.getPaylo

Re: Stratos is not setting user meta data to instances created in GCE

2015-06-02 Thread Asanka Sanjaya Herath
Hi Isuru and Gayan, I'll follow the steps you mentioned and update the thread ASAP. On Wed, Jun 3, 2015 at 6:00 AM, Isuru Haththotuwa wrote: > Hi Asanka, > > Great work in finding this! > > Can you check what are the values that are coming in the payload for the > setDynamicPayload function? >

Re: Stratos is not setting user meta data to instances created in GCE

2015-06-02 Thread Isuru Haththotuwa
Hi Asanka, Great work in finding this! Can you check what are the values that are coming in the payload for the setDynamicPayload function? In both EC2IaaS and OpenStackIaaS this check is not there. Can you test removing 'iaasInfo.getPayload() == null' check? On Wed, Jun 3, 2015 at 11:15 AM, As

Re: Stratos is not setting user meta data to instances created in GCE

2015-06-02 Thread Gayan Gunarathne
Hi Asanka, Can you please check why iaasInfo.getPayload() has a null value? Seems there is a issue with the payload generation. You can check this by adding the debug points to the createPayload method in the AS ApplicationUtils class or enabling the debug logs in the AS? Thanks, Gayan On Wed,

Stratos is not setting user meta data to instances created in GCE

2015-06-02 Thread Asanka Sanjaya Herath
Hi All, I did some debugging on $subject and I found that there is a problem in GCEIaas.java class located in cloud controller component. In line 184, iaasInfo.getPayload() is always has a null value. So the method setDynamicPayload() will return immediately without setting user metadata to the i