Hi Akila,
I have added a unit test called ThriftStatisticsPublisherTest in the same
p/r.
Thanks.
On Mon, Nov 30, 2015 at 1:57 PM, Akila Ravihansa Perera
wrote:
> Hi Thanuja,
>
> I've added more comments, please check. Could you write a simple unit test
> to assert whether dataPublisherHolders
Hi Thanuja,
I've added more comments, please check. Could you write a simple unit test
to assert whether dataPublisherHolders and receiverGroups objects are
populated correctly?
Thanks.
On Mon, Nov 30, 2015 at 1:44 PM, Thanuja Uruththirakodeeswaran <
thanu...@wso2.com> wrote:
> Please review an
Please review and merge this p/r [1].
[1]. https://github.com/apache/stratos/pull/496
Thanks.
On Mon, Nov 30, 2015 at 1:38 PM, Gayan Gunarathne wrote:
>
>
> On Mon, Nov 30, 2015 at 1:33 PM, Thanuja Uruththirakodeeswaran <
> thanu...@wso2.com> wrote:
>
>> Fixed it with commit [1].
>>
>> [1].
>>
On Mon, Nov 30, 2015 at 1:33 PM, Thanuja Uruththirakodeeswaran <
thanu...@wso2.com> wrote:
> Fixed it with commit [1].
>
> [1].
> https://github.com/Thanu/stratos/commit/c5df03d3e6a8bab930518f69baa62aae88a5bcbe
>
Great. Could you please send a PR for this?
Thanks,
Gayan
>
> On Mon, Nov 30, 2015
Fixed it with commit [1].
[1].
https://github.com/Thanu/stratos/commit/c5df03d3e6a8bab930518f69baa62aae88a5bcbe
On Mon, Nov 30, 2015 at 12:32 PM, Akila Ravihansa Perera wrote:
> IMO, it should be "cep310" (instead of "cep.310")
>
> On Mon, Nov 30, 2015 at 11:36 AM, Gayan Gunarathne
> wrote:
>
IMO, it should be "cep310" (instead of "cep.310")
On Mon, Nov 30, 2015 at 11:36 AM, Gayan Gunarathne wrote:
> /s/cep301/cep310
>
> On Mon, Nov 30, 2015 at 11:32 AM, Gayan Gunarathne
> wrote:
>
>> I found the $subject for CEP300[1] and CEP301[2]. What is the ration
>> behind that or is that a mi
/s/cep301/cep310
On Mon, Nov 30, 2015 at 11:32 AM, Gayan Gunarathne wrote:
> I found the $subject for CEP300[1] and CEP301[2]. What is the ration
> behind that or is that a mistake?
>
> [1]
> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2ce
I found the $subject for CEP300[1] and CEP301[2]. What is the ration behind
that or is that a mistake?
[1]
https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.0.0/pom.xml#L30
[2]
https://github.com/apache/stratos/blob/stratos-4.1.x/extensions