svn commit: r289901 - /struts/shale/trunk/clay-plugin/src/conf/view-config.dtd

Author: wsmoak Date: Sat Sep 17 23:53:11 2005 New Revision: 289901 URL: http://svn.apache.org/viewcvs?rev=289901&view=rev Log: Removed duplicate/unused DTD. (clay-config_1_0.dtd is in use.) Removed: struts/shale/trunk/clay-plugin/src/conf/view-config.dtd

svn commit: r289899 - in /struts/shale/trunk/use-cases/src/web/WEB-INF: applicationContext.xml chain-config.xml clay-config.xml daoContext.xml dialog-config.xml faces-config.xml validator-rules.xml web.xml

Author: wsmoak Date: Sat Sep 17 23:35:59 2005 New Revision: 289899 URL: http://svn.apache.org/viewcvs?rev=289899&view=rev Log: Updated use-cases clay config file with new doctype declaration Added missing svn props Modified: struts/shale/trunk/use-cases/src/web/WEB-INF/applicationContext.xml

svn commit: r289898 - /struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/resources/

Author: wsmoak Date: Sat Sep 17 23:18:31 2005 New Revision: 289898 URL: http://svn.apache.org/viewcvs?rev=289898&view=rev Log: Removed empty directory; DTD was moved to src/conf/. Removed: struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/resources/ -

svn commit: r289896 - in /struts/shale/trunk/clay-plugin/src: conf/clay-config_1_0.dtd java/org/apache/shale/clay/config/resources/clay-config_1_0.dtd

Author: wsmoak Date: Sat Sep 17 23:04:12 2005 New Revision: 289896 URL: http://svn.apache.org/viewcvs?rev=289896&view=rev Log: Moved DTD to src/conf Added: struts/shale/trunk/clay-plugin/src/conf/clay-config_1_0.dtd - copied unchanged from r289895, struts/shale/trunk/clay-plugin/src/ja

svn commit: r289895 - in /struts/shale/trunk/clay-plugin/src: conf/faces-config.xml conf/shale-clay.tld conf/view-config.dtd conf/view-config.xml java/org/apache/shale/clay/config/resources/clay-confi

Author: wsmoak Date: Sat Sep 17 23:03:11 2005 New Revision: 289895 URL: http://svn.apache.org/viewcvs?rev=289895&view=rev Log: Added missing svn props Modified: struts/shale/trunk/clay-plugin/src/conf/faces-config.xml (props changed) struts/shale/trunk/clay-plugin/src/conf/shale-clay.tl

svn commit: r289892 [3/3] - in /struts/shale/trunk/clay-plugin: ./ src/conf/ src/java/org/apache/shale/clay/config/ src/java/org/apache/shale/clay/config/resources/ src/test/org/apache/shale/clay/conf

Modified: struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/ClayXmlParser.java URL: http://svn.apache.org/viewcvs/struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/config/ClayXmlParser.java?rev=289892&r1=289891&r2=289892&view=diff ===

svn commit: r289892 [1/3] - in /struts/shale/trunk/clay-plugin: ./ src/conf/ src/java/org/apache/shale/clay/config/ src/java/org/apache/shale/clay/config/resources/ src/test/org/apache/shale/clay/conf

Author: wsmoak Date: Sat Sep 17 22:51:48 2005 New Revision: 289892 URL: http://svn.apache.org/viewcvs?rev=289892&view=rev Log: Added suggested doctype declaration to clay-config DTD. Changed related files to conform to the new label and location. Updated build file to copy DTD into org/apache/shal

Re: [Shale] AbstractJsfTestCase factory methods

On 9/17/05, Gary VanMatre <[EMAIL PROTECTED]> wrote: > > > On 9/17/05, Gary VanMatre wrote: > > > > > > I was thinking that it might be helpful to have some protected factory > > > > methods on the AbstractJsfTestCase for instantiating the environment > mock > > > objects like request, respo

Re: [Shale] AbstractJsfTestCase factory methods

> On 9/17/05, Gary VanMatre wrote: > > > > I was thinking that it might be helpful to have some protected factory > > methods on the AbstractJsfTestCase for instantiating the environment mock > > objects like request, response, faces context, ... > > > I can see why one might want to do that

Re: [Shale] AbstractJsfTestCase factory methods

On 9/17/05, Gary VanMatre <[EMAIL PROTECTED]> wrote: > > I was thinking that it might be helpful to have some protected factory > methods on the AbstractJsfTestCase for instantiating the environment mock > objects like request, response, faces context, ... I can see why one might want to do th

[Shale] AbstractJsfTestCase factory methods

I was thinking that it might be helpful to have some protected factory methods on the AbstractJsfTestCase for instantiating the environment mock objects like request, response, faces context, ... This would be a place that you could override and provide your own mock implementation for a test c

svn commit: r289885 - in /struts/shale/trunk/core-library/src/test/org/apache/shale/view: ConcreteFacesBean.java ConcreteFacesBeanTestCase.java ConcreteViewController.java ConcreteViewControllerTestCa

Author: craigmcc Date: Sat Sep 17 20:51:21 2005 New Revision: 289885 URL: http://svn.apache.org/viewcvs?rev=289885&view=rev Log: Add test cases for o.a.s.v.{AbstractFacesBean,AbstractViewController} Added: struts/shale/trunk/core-library/src/test/org/apache/shale/view/ConcreteFacesBean.java

svn commit: r289884 - /struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/parser/builder/Builder.java

Author: gvanmatre Date: Sat Sep 17 20:50:31 2005 New Revision: 289884 URL: http://svn.apache.org/viewcvs?rev=289884&view=rev Log: Optimized the loop for moving HTML attributes over the corresponding defined in the XML config files. Modified: struts/shale/trunk/clay-plugin/src/java/org/apa

DO NOT REPLY [Bug 36698] New: - Enhancements for ActionRedirect

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [shale] Clay DTD

> From: "Gary VanMatre" > > > We should fix this and I don't think we have to worry about breaking > > anything since it's already broken:-) I can hack on it unless you already > > have it fixed. > > I have it part of the way done... let me give it a try and then you can fix > it if I get i

svn commit: r289883 - /struts/shale/trunk/core-library/build.xml

Author: craigmcc Date: Sat Sep 17 20:03:56 2005 New Revision: 289883 URL: http://svn.apache.org/viewcvs?rev=289883&view=rev Log: Restore use of "-enableassertions" without the "-D" option, since it actually does activate insertion generation. Modified: struts/shale/trunk/core-library/build.xm

Re: svn commit: r289712 - in /struts/shale/trunk/core-library: ./ src/java/org/apache/shale/dialog/faces/ src/java/org/apache/shale/util/

On 9/17/05, Wendy Smoak <[EMAIL PROTECTED]> wrote: > > Wrom: > KBRNVWWCUFPEGAUTFJMVRESKPNKMBIPBARHDMNNSKVFVWRKJVZCMHVIBGDADRZFSQHYUCDDJBLVLMHAALPTCXLYRWTQTIPWIGYOKSTTZRCLBDXRQBGJSNBOHMKHJYFMYXOEAIJJPHSCRTNHGSWZIDREXCAXZOWCONEUQZAAFXISHJEXXIMQZUIVOTQNQEMSFDULHPQQWOYIYZUNNYCGPKYLEJGDGVCJVTLBXFGGMEP

Re: [shale] Clay DTD

From: "Gary VanMatre" <[EMAIL PROTECTED]> We should fix this and I don't think we have to worry about breaking anything since it's already broken:-) I can hack on it unless you already have it fixed. I have it part of the way done... let me give it a try and then you can fix it if I get it

Re: svn commit: r289712 - in /struts/shale/trunk/core-library: ./ src/java/org/apache/shale/dialog/faces/ src/java/org/apache/shale/util/

From: "Craig McClanahan" <[EMAIL PROTECTED]> On 9/17/05, Martin Cooper <[EMAIL PROTECTED]> wrote: > + > > I believe you meant -Denableassertions... (i.e. missing a 'D') Yep, good catch ... thanks. Craig, I think you had it right. The output of 'java -help' shows -enableassertions as a se

Re: [shale] Clay DTD

> > I noticed that a few of the xml files in clay-plugin and use-cases refer to: > > > "-//Apache Software Foundation//DTD Shale Clay View//EN" > "http://jakarta.apache.org/struts/dtds/clay-config_1_1.dtd";> > Oh, good catch. I think that one should be "clay-config_1_0.dtd" > This doesn't

svn commit: r289881 - in /struts/shale/trunk/build: README.txt core-test/project.properties project.properties

Author: wsmoak Date: Sat Sep 17 19:46:20 2005 New Revision: 289881 URL: http://svn.apache.org/viewcvs?rev=289881&view=rev Log: - Set the source level to 1.4 for the project (Maven defaults to 1.3) - Fork and enable assertions for the core-library tests - Update the build README file Modified:

svn commit: r289879 - in /struts/shale/trunk/core-library/src/test/org/apache/shale/view: ./ impl/ impl/DefaultViewControllerMapperTestCase.java

Author: craigmcc Date: Sat Sep 17 18:49:19 2005 New Revision: 289879 URL: http://svn.apache.org/viewcvs?rev=289879&view=rev Log: Unit tests for DefaultViewControllerMapper. Added: struts/shale/trunk/core-library/src/test/org/apache/shale/view/ struts/shale/trunk/core-library/src/test/org/

svn commit: r289877 - in /struts/shale/trunk/xdocs: features.xml index.xml

Author: wsmoak Date: Sat Sep 17 17:54:12 2005 New Revision: 289877 URL: http://svn.apache.org/viewcvs?rev=289877&view=rev Log: Minor editing of website docs Modified: struts/shale/trunk/xdocs/features.xml struts/shale/trunk/xdocs/index.xml Modified: struts/shale/trunk/xdocs/features.xml

DO NOT REPLY [Bug 36521] - [shale] TilesViewHandler should not assume ServletResponse and ServletContext

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r289875 - /struts/shale/trunk/core-library/src/java/org/apache/shale/tiles/TilesViewHandler.java

Author: craigmcc Date: Sat Sep 17 17:46:18 2005 New Revision: 289875 URL: http://svn.apache.org/viewcvs?rev=289875&view=rev Log: Make TilesViewHandler work correctly even in a portlet environment, by skipping the tile lookup (instead of throwing a class cast exception). PR: Bugzilla #36521 Submi

DO NOT REPLY [Bug 36695] - [shale] Test case for TokenProcessor fails

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

[shale] Clay DTD

I noticed that a few of the xml files in clay-plugin and use-cases refer to: http://jakarta.apache.org/struts/dtds/clay-config_1_1.dtd";> This doesn't seem to exist... the only thing I can find is /clay-plugin/src/java/org/apache/struts/clay/config/resources/clay-config_1_0.dtd and that has no

svn commit: r289874 - /struts/shale/trunk/core-library/src/java/org/apache/shale/util/TokenProcessor.java

Author: craigmcc Date: Sat Sep 17 17:30:45 2005 New Revision: 289874 URL: http://svn.apache.org/viewcvs?rev=289874&view=rev Log: Improve algorithm for generating tokens so that out-of-order timestamps do not cause a problem. PR: Bugzilla #36695 Submitted by: Manfred Klug Modified: struts

svn commit: r289871 - in /struts/shale/trunk/core-library: build.xml src/test/org/apache/shale/util/TokenProcessorTestCase.java

Author: craigmcc Date: Sat Sep 17 17:13:51 2005 New Revision: 289871 URL: http://svn.apache.org/viewcvs?rev=289871&view=rev Log: Windows does not seem to like Thread.sleep(2), so change the test methodology to just generate 1000 unique tokens. Also, fix a typo in the build.xml to actually enable

Re: svn commit: r289712 - in /struts/shale/trunk/core-library: ./ src/java/org/apache/shale/dialog/faces/ src/java/org/apache/shale/util/

On 9/17/05, Martin Cooper <[EMAIL PROTECTED]> wrote: > > + > > I believe you meant -Denableassertions... (i.e. missing a 'D') Yep, good catch ... thanks. -- > Martin Cooper Craig

Re: svn commit: r289712 - in /struts/shale/trunk/core-library: ./ src/java/org/apache/shale/dialog/faces/ src/java/org/apache/shale/util/

+ I believe you meant -Denableassertions... (i.e. missing a 'D') -- Martin Cooper On 9/17/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Author: craigmcc > Date: Sat Sep 17 00:23:11 2005 > New Revision: 289712 > > URL: http://svn.apache.org/viewcvs?rev=289712&view=rev > Log: > Fun with

Re: svn commit: r289497 - in /struts/core/trunk/xdocs/userGuide: building_controller.xml building_model.xml building_view.xml

On Fri, 2005-09-16 at 11:54 +, [EMAIL PROTECTED] wrote: > Modified: struts/core/trunk/xdocs/userGuide/building_view.xml > URL: > http://svn.apache.org/viewcvs/struts/core/trunk/xdocs/userGuide/building_view.xml?rev=289497&r1=289496&r2=289497&view=diff >

Re: svn commit: r280838 - /struts/core/trunk/xdocs/userGuide/preface.xml

On Wed, 2005-09-14 at 12:54 +, [EMAIL PROTECTED] wrote: > @@ -851,7 +851,7 @@ > > > > -The features provided by the Struts framework relies on a number of > objects that are > +The features provided by the Struts Core framework relies on a number > of objects that are s

Re: svn commit: r280836 - in /struts: core/trunk/xdocs/ core/trunk/xdocs/userGuide/ site/trunk/xdocs/

A couple of typos. On Wed, 2005-09-14 at 12:34 +, [EMAIL PROTECTED] wrote: > @@ -229,7 +229,7 @@ > > > > -In a later release, > +In a later release, when the new members stabalize, s/stabalize/stabilize > Modified: struts/core/trunk/xdocs/userGu

Re: Wrapping Struts tags in tag files

Ted Husted wrote: In general, we work by lazy consensus. If no one squawks, we sally forth. OK, before I sally ;-) I've been thinking a little more about this change. There are two approaches that seem reasonable, one of which minimized changes in the code and one of which minimizes the amou

Re: Multiple Struts Config / Multiple Validator Config

Joe Germuska wrote: At 2:17 PM -0400 9/17/05, Laurie Harper wrote: On a slight tangent, what happens if you're using wild-card action mapping paths? When Struts matches URLs against mapping paths the last match wins, which means you have to be careful about the order you define your actions i

[PATCH] (3 of 3) Cactus test fixes for taglib subproject

The following diff cleans up the remaining test failures. Again, the changes are trivial: the order attributes are generated in the output HTML changed, and a couple of the tests weren't setting up the expected results correctly (hard-coding the server name). To quickly run the test case in is

Re: Multiple Struts Config / Multiple Validator Config

At 2:17 PM -0400 9/17/05, Laurie Harper wrote: On a slight tangent, what happens if you're using wild-card action mapping paths? When Struts matches URLs against mapping paths the last match wins, which means you have to be careful about the order you define your actions in. In my application I

[PATCH] (2 of 3) Cactus test fixes for taglib subproject

The following diff removes a set of tests dealing with the 'locale' attribute of HtmlTag, which was removed in revision 234386. The patch just deletes the affected (no longer applicable) tests from the TestCase and corresponding JSP. To quickly run the test case in isolation before/after patch

[PATCH] (1 of 3) Cactus test fixes for taglib subproject

The following two posts contain two patches which clean up the Cactus tests is the taglibs subproject, fixing all test failures. The patches are trivial; the failures were a result of minor bit-rot in the tests. Running the Cactus tests is easy enough, but there's one issue I haven't resolved

DO NOT REPLY [Bug 36643] - [shale] Problem with the processing of clay templates.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Multiple Struts Config / Multiple Validator Config

On a slight tangent, what happens if you're using wild-card action mapping paths? When Struts matches URLs against mapping paths the last match wins, which means you have to be careful about the order you define your actions in. In my application I have a general 'catch-all' mapping with the pa

DO NOT REPLY [Bug 36643] - [shale] Problem with the processing of clay templates.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Multiple Struts Config / Multiple Validator Config

We routinely decompose all of our key struts config files into smaller units: struts-config, validation, and tiles-definitions. It is true that you can only define the validator plugin once, but when you define it, you can give it a list of configs. Our typical setup looks something like this

DO NOT REPLY [Bug 36643] - [shale] Problem with the processing of clay templates.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 36521] - [shale] TilesViewHandler should not assume ServletResponse and ServletContext

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 36695] - [shale] Test case for TokenProcessor fails

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 36695] New: - [shale] Test case for TokenProcessor fails

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r289713 - /struts/shale/trunk/docs/release-notes-1.0.0.html

Author: craigmcc Date: Sat Sep 17 00:25:35 2005 New Revision: 289713 URL: http://svn.apache.org/viewcvs?rev=289713&view=rev Log: Update release notes to reflect the assertion enabling options. Modified: struts/shale/trunk/docs/release-notes-1.0.0.html Modified: struts/shale/trunk/docs/releas

svn commit: r289712 - in /struts/shale/trunk/core-library: ./ src/java/org/apache/shale/dialog/faces/ src/java/org/apache/shale/util/

Author: craigmcc Date: Sat Sep 17 00:23:11 2005 New Revision: 289712 URL: http://svn.apache.org/viewcvs?rev=289712&view=rev Log: Fun with assert statements, part 1. Since Shale depends on JDK 1.4 or later, stick in some "assert" statements for the classes that currently have unit test cases, and m

Re: Wrapping Struts tags in tag files

Laurie Harper wrote: Laurie Harper wrote: Ted Husted wrote: On 9/14/05, Laurie Harper <[EMAIL PROTECTED]> wrote: James Mitchell setup some automatic tests for the taglib, though a lot of the behavior is still tested through the tag-exercises application. Niall is correct. When I've applied ta