Re: [Shale] generic renderer decorators

On 1/20/06, Gary VanMatre <[EMAIL PROTECTED]> wrote: > > I'll looking for feedback and would like to start some discussion on an > idea that might be a nice Shale add-on. What do you think about the second > approach in this ticket? > > http://issues.apache.org/bugzilla/show_bug.cgi?id=37932 > > W

Re: svn commit: r370938 [1/50] - in /struts: action/trunk/ action/trunk/conf/java/ action/trunk/src/java/org/apache/struts/ action/trunk/src/java/org/apache/struts/action/ action/trunk/src/java/org/ap

I haven't time to look through all 50 commit messages for this change - but a quick look at a few of the messages already brought up a couple of issues: * The reformatting of the svn keyswords @version $Rev$ $Date$ has moved the $ sign from the end of Date to the next line - effectively disabling

svn commit: r370938 [50/50] - in /struts: action/trunk/ action/trunk/conf/java/ action/trunk/src/java/org/apache/struts/ action/trunk/src/java/org/apache/struts/action/ action/trunk/src/java/org/apach

Modified: struts/build/trunk/pom.xml URL: http://svn.apache.org/viewcvs/struts/build/trunk/pom.xml?rev=370938&r1=370937&r2=370938&view=diff == --- struts/build/trunk/pom.xml (original) +++ struts/build/trunk/pom.xml Fri Ja

svn commit: r370938 [41/50] - in /struts: action/trunk/ action/trunk/conf/java/ action/trunk/src/java/org/apache/struts/ action/trunk/src/java/org/apache/struts/action/ action/trunk/src/java/org/apach

Modified: struts/action/trunk/xdocs/userGuide/release-notes-1.1-b1.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/xdocs/userGuide/release-notes-1.1-b1.xml?rev=370938&r1=370937&r2=370938&view=diff == --- struts/

svn commit: r370938 [29/50] - in /struts: action/trunk/ action/trunk/conf/java/ action/trunk/src/java/org/apache/struts/ action/trunk/src/java/org/apache/struts/action/ action/trunk/src/java/org/apach

Modified: struts/action/trunk/xdocs/roadmap.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/xdocs/roadmap.xml?rev=370938&r1=370937&r2=370938&view=diff == --- struts/action/trunk/xdocs/roadmap.xml (original) +++

svn commit: r370938 [3/50] - in /struts: action/trunk/ action/trunk/conf/java/ action/trunk/src/java/org/apache/struts/ action/trunk/src/java/org/apache/struts/action/ action/trunk/src/java/org/apache

Modified: struts/action/trunk/src/java/org/apache/struts/action/ActionMessages.java URL: http://svn.apache.org/viewcvs/struts/action/trunk/src/java/org/apache/struts/action/ActionMessages.java?rev=370938&r1=370937&r2=370938&view=diff ===

DO NOT REPLY [Bug 38338] New: - NullPointerException in selectModule when tiles plugin set to moduleAware=true

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Checkstyle (was svn commit: r360442 [1/3] )

Actually, someone pointed out to me off-list that FindBugs is in the Maven repository... I was confused, JLint is the native app that requires some setup. I was confusing the two. Of course, now I have *NO* idea why I stopped using FindBugs, I'll have to go play a bit tonight :) Frank Fran

Re: Checkstyle (was svn commit: r360442 [1/3] )

Agreed, and for a while I was in fact using it... I think the only real reason I stopped is because I couldn't figure out how to make it work from Ant *without* having to first install it (concerns about portability for new developers). Your absolutely right though, it's excellent. JLint is a

Re: Checkstyle (was svn commit: r360442 [1/3] )

On 1/20/06, Frank W. Zammetti <[EMAIL PROTECTED]> wrote: > > ...but I think what's more important to note is that Checkstyle doesn't > just catch simple formatting problems, it catches code smells and things > that can cause subtle problems > > The kinds of things I'm talking about are covered by r

Re: Checkstyle (was svn commit: r360442 [1/3] )

...but I think what's more important to note is that Checkstyle doesn't just catch simple formatting problems, it catches code smells and things that can cause subtle problems The kinds of things I'm talking about are covered by rules like DefaultComesLast, FallThrough, HiddenField, IllegalCat

Re: Checkstyle (was svn commit: r360442 [1/3] )

I think it is more of a "broken windows" kind of thing. For a long time, we've ignored Checkstyle but recently, there has been some concern that we not let our code degenerate, at least regards to formatting. These types of issues usually come up around release time. Don Patrick Lightbody wr

[Shale] generic renderer decorators

I'll looking for feedback and would like to start some discussion on an idea that might be a nice Shale add-on. What do you think about the second approach in this ticket? http://issues.apache.org/bugzilla/show_bug.cgi?id=37932 What do think about making this more of a generic feature so that

Re: Checkstyle (was svn commit: r360442 [1/3] )

Just curious: what is the motivation for the checkstyle process in the first place? Code standards can be important, but usually it isn't my top concern. Is there some Apache requirement that the checkstyle process run? - Posted

Re: Checkstyle (was svn commit: r360442 [1/3] )

On 1/20/06, Patrick Lightbody <[EMAIL PROTECTED]> wrote: > I think asking developers to run _two_ tasks on every check-in is a bit much. > Perhaps we > can set up a process where we just do that every X weeks, or the end of the > month? Most of us use the Maven build, if not to build the project

Re: Checkstyle (was svn commit: r360442 [1/3] )

We had good luck with Jalopy, though sometimes it would touch files that it didn't need to. Overall we've had good not being too formal with the style and then once in a while (maybe 3-6 months) someone would run the IDEA reformat on the entire codebase. I think the important theme should be to

Re: Checkstyle (was svn commit: r360442 [1/3] )

On 1/19/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: > Try reverting to version 1.3.1 of the plugin OK, that worked just fine, and I can run Jalopy as a Maven task. Of course, as Frank reported, Jalopy is not reformatting everything it could, especialy long lines. I tried reformatting the Action s

[Struts Wiki] Update of "StrutsConsultants" by robK

Dear Wiki user, You have subscribed to a wiki page or wiki category on "Struts Wiki" for change notification. The following page has been changed by robK: http://wiki.apache.org/struts/StrutsConsultants -- * NSE Sof